[Mass] Fix point topological changes for UniformMass#2853
Merged
hugtalbot merged 6 commits intosofa-framework:masterfrom May 16, 2022
Merged
[Mass] Fix point topological changes for UniformMass#2853hugtalbot merged 6 commits intosofa-framework:masterfrom
hugtalbot merged 6 commits intosofa-framework:masterfrom
Conversation
epernod
requested changes
Apr 11, 2022
Contributor
|
Thank you for this PR, it highlights a more serious bug when adding elements in TopologySubsetData. A PR to fix the TopologySubsetData is coming, then we will update this PR to adapt UniformMass with the good callbacks. Right now the callback on PointRemoved event proposed in this PR will crash as the TopologySubsetData already has an internal mechanism to update its size. So you perform the deletion twice. |
Contributor
|
Update the FIX but now this PR depends on change done in PR #2870 |
Contributor
Author
Contributor
|
@hugtalbot now that #2869 has been merged, you can review the #2870, then this one will be the following... |
Contributor
|
[ci-build][with-all-tests] |
hugtalbot
commented
May 4, 2022
ece45e7 to
9d4e313
Compare
…e an option of UniformMass. Support is automatic if the mass is linked to a dynamic topology
9d4e313 to
5ce37c0
Compare
epernod
approved these changes
May 15, 2022
Contributor
|
@hugtalbot this one is ready for me. Could you double check and merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #2870
The topological callback was actually not working for the UniformMass.
Now POINTSADDED and POINTSREMOVED are handled
in addition:
Thanks to @Oparras for rising this in #2668
A regression could be added on this scene
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if