Skip to content

[SofaGeneralDeformable] Remove TopologyHandler in FEM to use TopologyData callbacks (part 3)#2389

Merged
fredroy merged 2 commits intosofa-framework:masterfrom
epernod:inf_FEM_DataHandler_up2
Oct 15, 2021
Merged

[SofaGeneralDeformable] Remove TopologyHandler in FEM to use TopologyData callbacks (part 3)#2389
fredroy merged 2 commits intosofa-framework:masterfrom
epernod:inf_FEM_DataHandler_up2

Conversation

@epernod
Copy link
Copy Markdown
Contributor

@epernod epernod commented Oct 8, 2021

Remove TopologyHandler instances in FEM and set topology callbacks directly using TopologyData thanks to PR #2375
Update FEM:

  • QuadularBendingSprings
  • TriangularBiquadraticSpringsForceField
  • TriangularQuadraticSpringsForceField
  • VectorSpringForceField

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

…ngs and VectorSpringForceField. Set callbacks directly in the TopologyData
…SpringsForceField and TriangularBiquadraticSpringsForceField. Set callbacks directly in the TopologyData
@epernod epernod added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 8, 2021
@epernod epernod self-assigned this Oct 8, 2021
@epernod epernod changed the title [SofaGeneralDeformable] Remove TopologyHandler in FEM to use TopologyData callbacks (part 2) [SofaGeneralDeformable] Remove TopologyHandler in FEM to use TopologyData callbacks (part 3) Oct 8, 2021
@epernod
Copy link
Copy Markdown
Contributor Author

epernod commented Oct 11, 2021

[ci-build][with-all-tests]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 14, 2021
@fredroy fredroy merged commit 873d340 into sofa-framework:master Oct 15, 2021
@epernod epernod deleted the inf_FEM_DataHandler_up2 branch October 20, 2021 22:30
@guparan guparan added this to the v21.12 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants