[SofaGeneralSimpleFem] Update BeamFEMForceField topologyHander and add tests#2382
Merged
alxbilger merged 3 commits intosofa-framework:masterfrom Oct 20, 2021
Merged
[SofaGeneralSimpleFem] Update BeamFEMForceField topologyHander and add tests#2382alxbilger merged 3 commits intosofa-framework:masterfrom
alxbilger merged 3 commits intosofa-framework:masterfrom
Conversation
… use directly TopologyData creation callback.
… data init and topological changes
Contributor
Author
|
[ci-build][with-all-tests] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
BeamFEMForceField:Activate
SofaGeneralSimpleFem_testby adding 8 tests inBeamFEMForceField_test.cppto test:This last test on topological change is failing because of the bug in UniformMass fixed in PR #2377
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if