Skip to content

[SofaGeneralSimpleFem] Update BeamFEMForceField topologyHander and add tests#2382

Merged
alxbilger merged 3 commits intosofa-framework:masterfrom
epernod:inf_BeamFEM
Oct 20, 2021
Merged

[SofaGeneralSimpleFem] Update BeamFEMForceField topologyHander and add tests#2382
alxbilger merged 3 commits intosofa-framework:masterfrom
epernod:inf_BeamFEM

Conversation

@epernod
Copy link
Copy Markdown
Contributor

@epernod epernod commented Oct 4, 2021

In BeamFEMForceField:

  • Remove TopologyHandler to directly use TopologyData creation callback.

Activate SofaGeneralSimpleFem_test by adding 8 tests in BeamFEMForceField_test.cpp to test:

  • Component creation with given values or default values
  • Error catching when creating without MechanicalObject
  • Error catching when creating without topology or with empty topology
  • value after init and after several simulation steps
  • Check update of the FEM while removing edges

This last test on topological change is failing because of the bug in UniformMass fixed in PR #2377


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: fix Fix a bug pr: new feature Implement a new feature pr: status to review To notify reviewers to review this pull-request labels Oct 4, 2021
@epernod
Copy link
Copy Markdown
Contributor Author

epernod commented Oct 5, 2021

[ci-build][with-all-tests]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 20, 2021
@alxbilger alxbilger merged commit 8f6eeb5 into sofa-framework:master Oct 20, 2021
@epernod epernod deleted the inf_BeamFEM branch October 31, 2021 19:28
@guparan guparan added this to the v21.12 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix Fix a bug pr: new feature Implement a new feature pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants