[SofaBaseTopology] Fix TopologySubsetData: call to creation/desctruction callback was missing#2374
Merged
epernod merged 2 commits intosofa-framework:masterfrom Oct 6, 2021
Merged
Conversation
…on callback method was missing during add/remove process
Contributor
Author
|
[ci-build][with-all-tests] |
hugtalbot
reviewed
Oct 6, 2021
|
|
||
| this->m_topologyHandler->applyCreateFunction(Index(size + i), t, empty_vecint, empty_vecdouble); | ||
|
|
||
| if (this->p_onCreationCallback) |
Contributor
There was a problem hiding this comment.
it could be the occasion to document (in the header file about the p_onDestructionCallback and p_onCreationCallback
guparan
pushed a commit
that referenced
this pull request
Oct 28, 2021
…2377) This PR depends on #2374 #2375 and #2376 and should be rebased before review. - Remove old method `handleTopologyChange` - Turn d_indices into TopologySubsetIndices, this automatically fix the topological changes update. - Fix the use of subset indices combined with topology changes. - Add callback on endingEvent to update the totalMass/vertexMass - Fix the center of gravity display when using subset of indices ______________________________________________________ Co-authored-by: Hugo <hugo.talbot@sofa-framework.org> Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
fredroy
added a commit
to fredroy/sofa
that referenced
this pull request
Nov 8, 2021
…ofa-framework#2377) This PR depends on sofa-framework#2374 sofa-framework#2375 and sofa-framework#2376 and should be rebased before review. - Remove old method `handleTopologyChange` - Turn d_indices into TopologySubsetIndices, this automatically fix the topological changes update. - Fix the use of subset indices combined with topology changes. - Add callback on endingEvent to update the totalMass/vertexMass - Fix the center of gravity display when using subset of indices ______________________________________________________ Co-authored-by: Hugo <hugo.talbot@sofa-framework.org> Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callback call in TopologySubsetData were missing:
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if