[InvertibleFVM] Externalize the plugin#1443
Merged
Merged
Conversation
guparan
suggested changes
Jul 30, 2020
Contributor
guparan
left a comment
There was a problem hiding this comment.
You should not mess with sofa_add_plugin calls order in applications/plugins/CMakeLists.txt, it's this way because of dependencies between plugins.
TODO: reset this file and just replace sofa_add_plugin(InvertibleFVM InvertibleFVM) by sofa_add_plugin_external(InvertibleFVM InvertibleFVM)
Contributor
Author
|
Hmm thanks @guparan I misunderstood the expected change 👍 |
…ertibleFVM # Conflicts: # applications/plugins/InvertibleFVM/CMakeLists.txt
Contributor
|
[ci-build][with-all-tests] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First plugin to be moved out, as detailed in issue #1442
Plugin is now located here: https://github.com/sofa-framework/InvertibleFVM
All feedback are more than welcome.
This PR:
Reviewers will merge only if all these checks are true.