Skip to content

[SofaMiscCollision] Fix topological changes in TetrahedronCollisionModel #1354

Merged
hugtalbot merged 2 commits intosofa-framework:masterfrom
epernod:inf_tetrahedronCModel
May 14, 2020
Merged

[SofaMiscCollision] Fix topological changes in TetrahedronCollisionModel #1354
hugtalbot merged 2 commits intosofa-framework:masterfrom
epernod:inf_tetrahedronCModel

Conversation

@epernod
Copy link
Copy Markdown
Contributor

@epernod epernod commented Apr 30, 2020

Fix TetrahedronModel topology handling and remove the old mechanism.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

epernod added 2 commits April 30, 2020 11:48
…ionModel. Update some scene to remove the TetrahedronModel alias and add the requiredplugin
@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Apr 30, 2020
@epernod epernod self-assigned this Apr 30, 2020
@epernod
Copy link
Copy Markdown
Contributor Author

epernod commented May 4, 2020

[ci-build][with-all-tests]

Comment thread applications/plugins/SofaMiscCollision/TetrahedronModel.cpp
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 13, 2020
@hugtalbot hugtalbot merged commit c2bb7b1 into sofa-framework:master May 14, 2020
@epernod epernod deleted the inf_tetrahedronCModel branch May 14, 2020 09:06
@guparan guparan added this to the v20.06 milestone Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants