[modules] Fix some warnings and OglAttribute handleTopologyChange#1159
Merged
fredroy merged 6 commits intosofa-framework:masterfrom Oct 9, 2019
Merged
[modules] Fix some warnings and OglAttribute handleTopologyChange#1159fredroy merged 6 commits intosofa-framework:masterfrom
fredroy merged 6 commits intosofa-framework:masterfrom
Conversation
…ing handleTopologyChange method and using a PointData for value.
| otherVertices.push_back(c.P); | ||
| otherVertices.push_back(c.P + c.norm); | ||
| otherColors.push_back(sofa::defaulttype::RGBAColor(0,0.5,0.5,1)); | ||
| otherColors.push_back(sofa::defaulttype::RGBAColor::white()); |
Contributor
Author
|
[ci-build][with-all-tests] |
Comment on lines
+105
to
+106
| const VecCoord& x1 = this->mstate1->read(core::ConstVecCoordId::restPosition())->getValue(); | ||
| const VecCoord& x2 = this->mstate2->read(core::ConstVecCoordId::restPosition())->getValue(); |
Contributor
There was a problem hiding this comment.
Sorry to ask late about htis but why do you change this ?
Shouldn't it be selectable by the user ?
Contributor
|
I have added just one small question i forgot to ask during the meeting; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fix from my working branch:
This PR:
Reviewers will merge only if all these checks are true.