-
Notifications
You must be signed in to change notification settings - Fork 848
chore: automate release process #1781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1781 +/- ##
=======================================
Coverage 85.15% 85.15%
=======================================
Files 115 115
Lines 13069 13069
=======================================
Hits 11129 11129
Misses 1940 1940 ☔ View full report in Codecov by Sentry. |
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilliamBergamin Once more, this is an awesome changeset 👾
I left a comment with thought on commit messages and share similar thoughts as in slackapi/bolt-python#1394 but please feel free to update these to what seems right of course!
.github/maintainers_guide.md
Outdated
| - Commit with a message including the new version number. For example `1.2.3` | ||
| & Push the commit to a branch and create a PR to sanity check. | ||
| - `git checkout -b 1.2.3-release` | ||
| - `git commit -m 'chore(release): tag version 1.2.3'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 thought: I'm a fan of this format, but wonder if we might want to include the package name here as well?
git commit -m 'chore(release): slack-sdk 1.2.3'
🗣️ ramble: This might not be the right convention, but I am thinking about adjacent projects in this comment...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep this simple for now 💯
Summary
This PR aims to automate the release process making it easier and simpler for maintainers to cut releases
Testing
Once this PR is merge we can manually run the release process in dry run and against test.pypi.org
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.