-
Notifications
You must be signed in to change notification settings - Fork 276
chore: automate release process #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
=======================================
Coverage 91.05% 91.05%
=======================================
Files 222 222
Lines 7534 7534
=======================================
Hits 6860 6860
Misses 674 674 ☔ View full report in Codecov by Sentry. |
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilliamBergamin LGTM! I did leave one question on our development release version schemes that we might want to revisit across all projects, so no blocker here 🚢 💨
Thanks for making these improvements too!
.github/maintainers_guide.md
Outdated
| - Example the current version is `1.2.3` a proper development bump would be | ||
| `1.2.3.dev0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️🗨️ thought: Is this something we want to change here?
🪬 ramble: I understand this project to use a different pattern than other projects at the moment, but IMHO incrementing the minor version can be useful in reviewing release orders:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point 💯 I'll update this
.github/maintainers_guide.md
Outdated
| 5. Name the release title after the version tag. It should match the updated | ||
| value from `slack_bolt/version.py`! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦔 quibble: An example might be nice to include! At quick glance I might not remember which format's saved to this file-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 🟢
.github/maintainers_guide.md
Outdated
| 10. (Slack Internal) Communicate the release internally | ||
| - Include a link to the GitHub release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎁 suggestion: We should follow up with automation to post to our release channel!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫡 praise: Farewell to deployment script. I am optimistic that these CI runs will help us in ongoing automation in kind.
Summary
This PR aims to automate the release process making it easier and simpler for maintainers to cut releases
Testing
Once this PR is merge we can manually run the release process in dry run and against test.pypi.org
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.