Changing the URL user id number in admin accounting table now refresh the table#509
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
=======================================
Coverage 95.25% 95.25%
=======================================
Files 88 88
Lines 3960 3960
Branches 248 248
=======================================
Hits 3772 3772
Misses 137 137
Partials 51 51Continue to review full report at Codecov.
|
Contributor
|
Write some selenium test. |
stefanoborini
suggested changes
Jun 6, 2017
stefanoborini
left a comment
Contributor
There was a problem hiding this comment.
needs some selenium tests.
When changing the url from an existing id "id1" to an unexisting id "id2", an issue is displayed but the table of the id "id1" is still displayed. In order to fix that we have to empty the table before trying to retrieve informations about the new id, so that if the new id is unknown, the table is empty as expected.
stefanoborini
suggested changes
Jun 9, 2017
| }, | ||
|
|
||
| watch: { | ||
| '$route.params.id': function() { |
Contributor
There was a problem hiding this comment.
clearTable();
updateTable();
| this.table.rows = []; | ||
| resources.Accounting.items({filter: JSON.stringify({user_id: this.$route.params.id })}) | ||
| .done((identifiers, items) => { | ||
| this.table.rows = []; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vue component now listens to changes of id and update the table.
Closes #441