Skip to content

Fix tables display issues#482

Merged
stefanoborini merged 8 commits into
masterfrom
fix_table_display_issues
Jun 5, 2017
Merged

Fix tables display issues#482
stefanoborini merged 8 commits into
masterfrom
fix_table_display_issues

Conversation

@martinRenou

Copy link
Copy Markdown
Member

We now use adminlte tables which are more responsive

@codecov-io

codecov-io commented Jun 1, 2017

Copy link
Copy Markdown

Codecov Report

Merging #482 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #482   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files          88       88           
  Lines        4077     4077           
  Branches      259      259           
=======================================
  Hits         3887     3887           
  Misses        138      138           
  Partials       52       52
Impacted Files Coverage Δ
...anager/handlers/admin/tests/test_admin_handlers.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff1154...b8c59a9. Read the comment docs.

@martinRenou martinRenou changed the title Fix tables display issues Fix tables display issues [WIP] Jun 1, 2017
@martinRenou martinRenou changed the title Fix tables display issues [WIP] Fix tables display issues Jun 1, 2017
@stefanoborini

Copy link
Copy Markdown
Contributor

Leave the button as it was before and the generalActions as well. We'll find a way of embedding the button in another component at a later stage.

@martinRenou

Copy link
Copy Markdown
Member Author

As you asked, I left the button as it was before. Excepted that I played with the CSS to display it on top of the datatable instead of on its side. It involves flex-box, but it will be susceptible to be removed when putting the button in the adminlte box header.

@stefanoborini stefanoborini merged commit 429da87 into master Jun 5, 2017
@stefanoborini stefanoborini deleted the fix_table_display_issues branch June 5, 2017 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants