Skip to content

Clear and add javascript tests#489

Merged
stefanoborini merged 7 commits into
masterfrom
fix_jstests
Jun 5, 2017
Merged

Clear and add javascript tests#489
stefanoborini merged 7 commits into
masterfrom
fix_jstests

Conversation

@martinRenou

@martinRenou martinRenou commented Jun 2, 2017

Copy link
Copy Markdown
Member
  • Add some javascript tests
  • Remove side effects in the tests
  • Clear code in the tests (by removing duplication using beforeEach routine)

@martinRenou martinRenou requested a review from stefanoborini June 2, 2017 16:59
@codecov-io

codecov-io commented Jun 5, 2017

Copy link
Copy Markdown

Codecov Report

Merging #489 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files          88       88           
  Lines        3952     3952           
  Branches      247      247           
=======================================
  Hits         3764     3764           
  Misses        137      137           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429da87...c69f4e9. Read the comment docs.

@stefanoborini stefanoborini merged commit c6a3acb into master Jun 5, 2017
@stefanoborini stefanoborini deleted the fix_jstests branch June 5, 2017 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants