Fix close button issue#481
Conversation
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
=======================================
Coverage 95.24% 95.24%
=======================================
Files 88 88
Lines 3952 3952
Branches 247 247
=======================================
Hits 3764 3764
Misses 137 137
Partials 51 51Continue to review full report at Codecov.
|
As it's not a "button" element but an "li" element, there is no disable attribute, we only play with the disabled class which change the visual effect but doesn't prevent the click event to be triggered. So the click event is still triggered and we have to deal with the case when the application is not currently running.
|
The solution is good, but I was wondering if we can actually prevent the click. Just curious. |
|
I changed it, it now prevents the click |
|
No, leave the check. It makes sense it's there. You can't operate if it's not running, but it should also prevent the click. |
|
Ok, so I should do the same for "StartApplication" and add a check in order to stay consistent |
|
Please add a test that the thing is actually not starting or stopping when those conditions happen. |
stefanoborini
left a comment
There was a problem hiding this comment.
Needs tests for the new code added
As it's not a "button" element but a "li" element, there is no disable attribute, we only play with the disabled class which change the visual aspect but doesn't prevent the click event to be triggered.
I fixed this by changing the
disabledclass which now prevents the mouse events.Closes #479