This repository was archived by the owner on Apr 23, 2021. It is now read-only.
Problem: BRAVAIS_LATTICE entry has ill-formatted PRIMITIVE_CELL default value#53
Merged
Merged
Conversation
Contributor
Author
|
@ahashibon please see this change. @stefanoborini please review this |
Contributor
Author
|
This change is already applied to simphony/simphony-common#329 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: remove the default value
BRAVAIS_LATTICECUBA entry has an array as its default value forPRIMITIVE_CELLattribute, however, we have so far no way to assign a default value for non-primitive CUBAs. Therefore this causes problems and I had to remove it and rely on the default value defined inPRIMITIVE_CELLitself.