This repository was archived by the owner on Apr 23, 2021. It is now read-only.
Command for meta build#329
Merged
Merged
Conversation
Contributor
I had to patch the generated modules in order to make tests pass. Namely, |
Contributor
Author
|
@mehdisadeghi Are you saying that the automatic generator produces something that is broken, and we need to patch the result manually? |
Contributor
Author
|
@mehdisadeghi if so, this needs fixing. |
Contributor
|
I replied to this in #330. |
Contributor
|
@stefanoborini please review the recent changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as a request for comments.
This PR introduces a setup command to build the meta classes, keywords and cuba from the metadata repository. Once merged, we can get rid of the verbatim copied files, which are redundant (as they are self-generated), prone to error, and tend to leave debris.
However, I note that there has been a change in behavior with the new generator or current metainfo, so much that now tests fail. I've seen some changes in the classes, especially in shapes that used to be
[1]and are now[]orNone.@mehdisadeghi does this make sense or is it a bug on this PR?
Please note that I had to work around some circular dependencies, so I might have missed something.