Skip to content

Fix LT-22450: Filtering causes wrong word to appear in Pop Up #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtmaxwell3 merged 1 commit into from
Mar 10, 2026
Merged

Fix LT-22450: Filtering causes wrong word to appear in Pop Up #748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions Src/xWorks/RecordClerk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,7 @@ public bool OnJumpToPopupRecord(object argument)
{
if (Id == "entries")
{
return JumpToRecord(argument, true);
return JumpToRecord(argument);
}
return false;
}
Expand All @@ -1080,7 +1080,7 @@ public bool OnJumpToRecord(object argument)
/// </summary>
/// <param name="argument">the hvo of the record</param>
/// <returns></returns>
bool JumpToRecord(object argument, bool popup = false)
Copy link
Contributor

@papeh papeh Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment about the purpose of popup would be helpful

Copy link
Collaborator Author

@jtmaxwell3 jtmaxwell3 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The popup parameter was deleted because it is no longer being used. It used to prevent the filter being cleared, but that was a mistake.

Copy link
Contributor

@papeh papeh Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, sorry! I was looking at your PR backwards and thought the param was being added. 🤦‍♂️

bool JumpToRecord(object argument)
{
CheckDisposed();

Expand Down Expand Up @@ -1125,10 +1125,7 @@ bool JumpToRecord(object argument, bool popup = false)
// update issue reported in (LT-2448). However, that message only works in the context of a
// BrowseViewer, not a document view (e.g. Dictionary) (see LT-7298). So, I've
// tested OnChangeFilterClearAll, and it seems to solve both problems now.
if (!popup)
{
OnChangeFilterClearAll(null);
}
OnChangeFilterClearAll(null);
m_activeMenuBarFilter = null;
index = IndexOfObjOrChildOrParent(hvoTarget);
}
Expand Down
Loading