Fix LT-22450: Filtering causes wrong word to appear in Pop Up#748
Merged
jtmaxwell3 merged 1 commit intomainfrom Mar 10, 2026
Merged
Fix LT-22450: Filtering causes wrong word to appear in Pop Up#748jtmaxwell3 merged 1 commit intomainfrom
jtmaxwell3 merged 1 commit intomainfrom
Conversation
papeh
reviewed
Mar 9, 2026
| /// </summary> | ||
| /// <param name="argument">the hvo of the record</param> | ||
| /// <returns></returns> | ||
| bool JumpToRecord(object argument, bool popup = false) |
Contributor
There was a problem hiding this comment.
A comment about the purpose of popup would be helpful
Collaborator
Author
There was a problem hiding this comment.
The popup parameter was deleted because it is no longer being used. It used to prevent the filter being cleared, but that was a mistake.
Contributor
There was a problem hiding this comment.
oops, sorry! I was looking at your PR backwards and thought the param was being added. 🤦♂️
papeh
approved these changes
Mar 10, 2026
| /// </summary> | ||
| /// <param name="argument">the hvo of the record</param> | ||
| /// <returns></returns> | ||
| bool JumpToRecord(object argument, bool popup = false) |
Contributor
There was a problem hiding this comment.
oops, sorry! I was looking at your PR backwards and thought the param was being added. 🤦♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22450. The filter needs to be cleared even when doing a pop up. This was introduced as part of https://jira.sil.org/browse/LT-22358, but it does not appear to be necessary. LT-22358 should be retested.
This change is