Merged
Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1002 +/- ##
==========================================
- Coverage 66.65% 66.63% -0.02%
==========================================
Files 40 40
Lines 6057 6060 +3
Branches 1014 1015 +1
==========================================
+ Hits 4037 4038 +1
- Misses 1661 1662 +1
- Partials 359 360 +1
🚀 New features to boost your workflow:
|
ilan-gold
approved these changes
May 21, 2025
Contributor
|
To catch this sort of thing, the project should use the |
Contributor
|
So in this PR, you could also add to the or do it locally and go one-by-one and catch any others that exist |
Contributor
|
I think it might need to be a double colon: https://docs.pytest.org/en/stable/how-to/capture-warnings.html#controlling-warnings sorry for the mistype |
ilan-gold
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #994
Without the fix this is the warning I get in a notebook:
I don't think it is possible to add a test case because in theory that part of the code is unreachable