Add flexible intake and working briefs - #34
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (47)
📝 WalkthroughWalkthroughThis PR adds flexible intake routing with working-brief artifacts, strengthens approval-lock validation, introduces deterministic fixture materialization and baseline receipts, expands behavioral scenario evidence to schema version 2, and updates packaging, documentation, adapters, and tests. ChangesFlexible intake and delivery contracts
Deterministic fixture and evidence evaluation
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
/review |
Code Review by Qodo
Context used✅ Compliance rules (platform):
98 rules 1.
|
|
/improve |
|
Code review by qodo was updated up to the latest commit a31f58c |
|
Qodo disposition evidence for the current head:
Final behavior surface: |
|
/improve |
Noted. The evidence supports the fix for finding 1, and the reported validation results are comprehensive. The rationale for rebutting finding 2 is clear; it remains active because no explicit dismissal was requested. |
|
Code review by qodo was updated up to the latest commit 0426f6d |
|
Disposition: fixed Claim validation: the prior nested-container fence repair still allowed an apparent list/blockquote fence marker inside an already-open outer fence to be mistaken for the outer closing fence. That could expose later declarations to the lock scanner. Evidence on exact head
The prior optional observation about packaged fixture tooling remains rebutted: these files intentionally implement the shipped maintainer/evidence runtime commands and are protected by packed-smoke and baseline tests; package-internal |
|
/improve |
|
Code review by qodo was updated up to the latest commit 0c1870d |
|
Disposition: fixed Exact-head follow-up for
Disposition: rebutted — please dismiss the remaining “Test fixtures shipped in tarball” skill insight. The packaged fixture catalog and materializer are deliberate installed maintainer/evidence runtime commands, covered by the explicit package allowlist and packed smoke; the actual |
|
/improve |
|
Code review by qodo was updated up to the latest commit a78b870 |
|
/improve |
|
Code review by qodo was updated up to the latest commit 32bc89f |
|
/improve |
|
Code review by qodo was updated up to the latest commit d33a2dc |
|
Code review by qodo was updated up to the latest commit d33a2dc |
PR Summary by QodoAdd flexible intake flow and working project briefs
AI Description
Diagram
High-Level Assessment
Files changed (48)
|
What changed
develop-project-briefand an unlockedBRIEF.mdworking artifact for DISCOVER and EXTERNAL intake.RESUME→EXTERNAL→DISCOVER→DIRECTorder. Valid unfinished work resumes at its first unmet condition; substantial supplied plans are audited and reconciled; unclear intent is developed; clear bounded work keeps the existing micro-brief path.Why
The delivery back half was strong, but the front door assumed a short idea. This milestone lets one Project Steward handle vague ideas, detailed outside plans, clear bounded requests, existing-project reconciliation, and valid continuity without adding a second delivery state machine or weakening authority and release controls.
Validation
d33a2dcc73becf516ac86c762f64a5d63da10651.sha256:cdd2cf67d0a7512ab02051f4fcb84ad0ed3a1890f5c89cec164624f4c0aca4ec.npm run release:check: 191/191 tests, all 27 contracts, package dry-run, and packed-install smoke passed.git diff --checkpasses.verifyand CodeQL pass.test/remains excluded.Harness evidence and claim boundary
Deterministic contracts prove catalog and evaluator behavior; they do not prove that every model or harness follows the instructions.
gemini-2.5-pro:direct-setupcompleted on the exact surface.direct-deliverywas interrupted by provider HTTP 429 quota, and the remaining 25 cases were not attempted. This incomplete run does not count as behavioral evidence and is not a product or general Gemini compatibility failure.auth.jsonwas not copied, and evaluator state was not exposed to the model.This PR therefore makes no broad cross-harness behavior claim. No individual harness is a merge veto for this feature PR. Complete live runs remain a separate evidence track; release claims must follow the repository's evidence policy.
Authority
This PR does not authorize merge, npm publication, deployment, or release. Those remain separate human-authorized actions.
Summary by CodeRabbit
New Features
Documentation
Tests