Harden project quality command policy by samtay32 · Pull Request #23 · samtay32/ultimate-agent-stack

samtay32 · 2026-07-28T04:13:07Z

Summary

fail closed on subcommand-specific Git and Terraform inspection arguments, paths, execution hooks, and environment overrides
run installed-project doctor checks through the protected local CLI instead of mutable @latest code
add adversarial containment regressions, submission-ready plugin metadata, and a standard security reporting policy

Root cause

The previous validator allowed a nominally read-only Git subcommand without constraining its options or inherited environment. Options such as git diff --no-index --output=... could therefore create or truncate files outside the project.

Verification

npm run release:check — 84 tests, package dry-run, and packed smoke passed
original outside-file creation/truncation exploit is rejected before execution
executable Git fsmonitor/config hooks are suppressed by the approved check environment
Git/Terraform option, path, and environment adversarial matrices pass
npx -y markdownlint-cli2@0.18.1 "**/*.md" — 50 files passed
git diff --check passed

Upgrade impact

Custom Git checks must use the documented bounded inspection forms, including --no-ext-diff and --no-textconv where required. Terraform formatting checks must use terraform fmt -check. Existing customized checks that fall outside this policy require explicit replacement and reapproval.

Summary by CodeRabbit

Security
- Strengthened validation, isolation, and safe parsing for Git and Terraform quality checks (stricter allowlists, read-only inspection enforcement, diff/log/show hardening, path escaping rejection).
- Hardened check execution by constraining Git behavior and tightening environment allowlisting.
- Added a private vulnerability reporting policy and security boundary guidance, plus upgrade/compatibility notes for custom checks.
Documentation
- Updated installation, setup, and operating instructions to use the local doctor command entrypoint.
- Linked the new security policy and expanded trust/check-constraint details.
Packaging
- Included SECURITY.md in published packages.

samtay32 · 2026-07-28T04:13:11Z

@coderabbitai review

coderabbitai · 2026-07-28T04:13:14Z

📝 Walkthrough

Walkthrough

The PR hardens Git and Terraform quality-check validation, disables configurable Git execution behaviors, replaces mutable-tag doctor commands with the local CLI, and adds a published security policy with related documentation and tests.

Changes

Quality Check Security Hardening

Layer / File(s)	Summary
Git and Terraform command validation `bin/ultimate-agent-stack.mjs`, `test/agent-stack.test.mjs`, `docs/TRUST.md`, `CHANGELOG.md`	Git and Terraform checks now enforce command, argument, revision, flag, and project-contained path allowlists, with tests covering accepted and rejected forms.
Git execution environment hardening `bin/ultimate-agent-stack.mjs`, `test/agent-stack.test.mjs`	Approved Git checks receive fixed environment controls, with regression coverage for external writes, fsmonitor execution, and restricted environment variables.

Local Doctor and Security Policy Distribution

Layer / File(s)	Summary
Local doctor command guidance `README.md`, `STARTER_PROMPT.md`, `assets/project-template/AGENTS.md`, `docs/OPERATING_MANUAL.md`, `skills/*`, `CHANGELOG.md`	Project instructions replace `npx ...@latest doctor` with the installed `node .agent-stack/bin/agent-stack.mjs doctor` command.
Security policy publication and metadata checks `SECURITY.md`, `package.json`, `README.md`, `.codex-plugin/plugin.json`, `test/maintenance.test.mjs`, `CHANGELOG.md`	A private vulnerability reporting policy is added and packaged, while maintenance tests enforce its inclusion, the local doctor guidance, and the shortened plugin description.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant QualityConfig
  participant validateCommand
  participant validateGitCommand
  participant runCheck
  participant Git
  QualityConfig->>validateCommand: submit Git or Terraform quality check
  validateCommand->>validateGitCommand: validate Git subcommand and arguments
  validateCommand-->>QualityConfig: allow or reject command
  QualityConfig->>runCheck: execute approved check
  runCheck->>Git: apply hardened environment and run inspection
  Git-->>runCheck: return inspection result

Possibly related PRs

samtay32/ultimate-agent-stack#10: Related package file-list updates and maintenance assertions for published artifacts.
samtay32/ultimate-agent-stack#15: Related runtime verification and quality.environment.allow hardening.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: tightening the project’s quality command policy and validations.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/security-command-policy-v072

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai · 2026-07-28T04:13:15Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

samtay32 · 2026-07-28T04:25:06Z

@coderabbitai review

coderabbitai · 2026-07-28T04:25:11Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

samtay32 · 2026-07-28T04:48:53Z

@coderabbitai full review

coderabbitai · 2026-07-28T04:48:58Z

✅ Action performed

Full review finished.

Your included review limit is currently reached under our Fair Usage Limits Policy. Your recent PR review activity is in the 95th percentile or higher among CodeRabbit users, so adaptive limits apply. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 25 minutes.

samtay32 · 2026-07-28T05:23:34Z

@coderabbitai full review

coderabbitai · 2026-07-28T05:23:40Z

✅ Action performed

Full review finished.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/agent-stack.test.mjs`:
- Around line 1746-1800: Strengthen both policy test matrices in
test/agent-stack.test.mjs:1746-1800 and test/agent-stack.test.mjs:1835-1856 by
associating each rejected argv with its expected Git or Terraform policy message
and asserting that message with assert.match instead of only checking a
non-empty error list. In the Git matrix, add a validateConfig(config, target)
case covering the projectArgumentSafe projectFile-containment branch; preserve
the existing rejection cases while ensuring each failure is attributed to the
intended rule.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cca4394b-198a-4a91-bee3-560bd207fc8d

📥 Commits

Reviewing files that changed from the base of the PR and between b796750 and 01c2cba.

📒 Files selected for processing (14)

.codex-plugin/plugin.json
CHANGELOG.md
README.md
SECURITY.md
STARTER_PROMPT.md
assets/project-template/AGENTS.md
bin/ultimate-agent-stack.mjs
docs/OPERATING_MANUAL.md
docs/TRUST.md
package.json
skills/run-autonomous-delivery/SKILL.md
skills/setup-autonomous-project/SKILL.md
test/agent-stack.test.mjs
test/maintenance.test.mjs

samtay32 · 2026-07-28T05:42:00Z

@coderabbitai review

coderabbitai · 2026-07-28T05:42:04Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Harden project quality command policy

01c2cba

coderabbitai Bot requested changes Jul 28, 2026

View reviewed changes

Comment thread test/agent-stack.test.mjs

Strengthen command policy assertions

643d4f7

coderabbitai Bot approved these changes Jul 28, 2026

View reviewed changes

samtay32 marked this pull request as ready for review July 28, 2026 05:46

samtay32 merged commit 761a1e3 into main Jul 28, 2026
13 checks passed

samtay32 deleted the codex/security-command-policy-v072 branch July 28, 2026 15:53

samtay32 mentioned this pull request Jul 28, 2026

chore: release v0.7.2 #25

Merged

This was referenced Jul 29, 2026

Add flexible intake and working briefs #34

Merged

Harden quality checks for 0.9.2 #38

Merged

Harden mechanical activation and independent-review receipts #40

Merged

Conversation

samtay32 commented Jul 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause

Verification

Upgrade impact

Summary by CodeRabbit

Uh oh!

samtay32 commented Jul 28, 2026

Uh oh!

coderabbitai Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samtay32 commented Jul 28, 2026

Uh oh!

coderabbitai Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samtay32 commented Jul 28, 2026

Uh oh!

coderabbitai Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samtay32 commented Jul 28, 2026

Uh oh!

coderabbitai Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

samtay32 commented Jul 28, 2026

Uh oh!

coderabbitai Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

samtay32 commented Jul 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading