Rollup of 29 pull requests - #160493
Merged
Merged
Conversation
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Co-authored-by: Clar Fon <15850505+clarfonthey@users.noreply.github.com>
```
error[E0277]: the trait bound `needs_borrow::Hello: needs_borrow::Tr` is not satisfied
--> $DIR/ownership-mismatch-on-arg.rs:42:13
|
LL | foo(hi, hi, hi);
| ^^^ -- -- `needs_borrow::Hello` doesn't satisfy the trait bound
| | |
| | `needs_borrow::Hello` doesn't satisfy the trait bound
| unsatisfied trait bound
|
help: the trait `needs_borrow::Tr` is not implemented for `needs_borrow::Hello`
--> $DIR/ownership-mismatch-on-arg.rs:27:5
|
LL | struct Hello;
| ^^^^^^^^^^^^
help: the trait `needs_borrow::Tr` is implemented for `&needs_borrow::Hello`
--> $DIR/ownership-mismatch-on-arg.rs:30:5
|
LL | impl Tr for &Hello {}
| ^^^^^^^^^^^^^^^^^^
note: required by a bound in `needs_borrow::foo`
--> $DIR/ownership-mismatch-on-arg.rs:32:15
|
LL | fn foo<T: Tr, K: std::fmt::Debug>(_v: T, _w: T, _k: K) {}
| ^^ required by this bound in `foo`
help: consider borrowing these argument
|
LL | foo(&hi, &hi, hi);
| + +
```
The linux kernel still uses fentry for x86 and s390x arches. s390x depends entirely on the compiler to record and nop these sections. This facilitates support for inserting nop's and/or recording the location of each mcount call in a special section named `__mcount_loc`. These attributes are currently only supported with fentry on the s390x target, otherwise they are quietly ignored (except on s390x).
* fix borrowck ICE for consts with fn pointer type annotate_argument_and_return_for_borrow called tcx.fn_sig on the item being checked whenever its type was FnDef or FnPtr. for a const whose type is a fn pointer that's not a function item, so we ICE'd with "unexpected sort of node in fn_sig". take the signature from the fn ptr type instead and skip the annotation when there's no fn decl. * run rustfmt and refmt * fix borrowck ICE for consts with fn pointer type annotate_argument_and_return_for_borrow called tcx.fn_sig on the item being checked whenever its type was FnDef or FnPtr. for a const whose type is a fn pointer that's not a function item, so we ICE'd with "unexpected sort of node in fn_sig". take the signature from the fn ptr type instead and skip the annotation when there's no fn decl. * edit comment * use ty.fn_sig per review
Member
Author
|
@bors r+ p=10 note="Rollup including a Docker pull change, hoping to fix CI" |
Contributor
This comment has been minimized.
This comment has been minimized.
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c9ff496 (parent) -> 0b63def (this PR) Test differencesShow 259 test diffsStage 1
Stage 2
Additionally, 206 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0b63defc8fd68957c635fe61f097b84df8fd9611 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: c9ff496891 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Aug 4, 2026
Collaborator
|
Finished benchmarking commit (0b63def): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -0.5%, secondary -0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -1.2%, secondary 0.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 489.838s -> 489.577s (-0.05%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
DepKindcleanups #160406 (DepKindcleanups)thread::available_parallelismas the default limit for backend parallelism #160424 (Usethread::available_parallelismas the default limit for backend parallelism)...without pattern post-expansion #160165 (reject...without pattern post-expansion)feature(stmt_expr_attributes)in2229_closure_analysistests #160172 (tests: Enablefeature(stmt_expr_attributes)in2229_closure_analysistests)platform-support.md#160305 (Linkify C-SKY targets inplatform-support.md)read_exact_bufandread_exact_buf_at#160371 (Add doc aliases for transpositionsread_exact_bufandread_exact_buf_at)borrowed_buf_init#160477 (Update the tracking issue forborrowed_buf_init)r? @ghost
Create a similar rollup