Run try builds on EC2 by default - #160427
Conversation
|
Warning If you are changing how CI LLVM is built or linked, make sure to bump cc @jieyouxu |
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Run try builds on EC2 by default
|
@rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors try jobs=dist-x86_64-linux-quick |
This comment has been minimized.
This comment has been minimized.
Run try builds on EC2 by default try-job: dist-x86_64-linux-quick
|
Finished benchmarking commit (d1299d6): comparison URL. Overall result: no relevant changes - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -2.1%, secondary -2.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 0.4%, secondary 1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 491.018s -> 490.201s (-0.17%) |
|
@bors try jobs=dist-x86_64-linux-quick-codebuild |
This comment has been minimized.
This comment has been minimized.
Run try builds on EC2 by default try-job: dist-x86_64-linux-quick-codebuild
|
@bors try jobs=dist-x86_64-linux |
This comment has been minimized.
This comment has been minimized.
Run try builds on EC2 by default try-job: dist-x86_64-linux
|
Okay, everything seems to work! |
|
@bors r+ rollup=never |
|
@bors rollup Actually, I guess it's totally fine to roll this up... |
…lacrum Run try builds on EC2 by default This PR switches try builds to EC2 instances by default, while still giving us the option to do a try build on codebuild. x64 Linux auto jobs are still using CodeBuild, for now. This script can be used to test the configuration of the generated CI jobs locally: ```bash #!/bin/bash #export GITHUB_EVENT_NAME=pull_request #export GITHUB_REF=refs/heads/pr/1 export GITHUB_EVENT_NAME=push export GITHUB_REF=refs/heads/automation/bors/try #export GITHUB_REF=refs/heads/automation/bors/auto #export COMMIT_MESSAGE="try-job: dist-x86_64-linux-quick" export COMMIT_MESSAGE="msg" export GITHUB_RUN_ID=123 export GITHUB_RUN_ATTEMPT=1 cargo run --manifest-path src/ci/citool/Cargo.toml calculate-job-matrix ``` CI runs: - `@bors try` - rust-lang#160427 (comment) (59m) - `@bors try jobs=dist-x86_64-linux-quick`: rust-lang#160427 (comment) (1h 32m) - `@bors try jobs=dist-x86_64-linux-codebuild`: rust-lang#160427 (comment) (3h 6m) - `@bors try jobs=dist-x86_64-linux`: rust-lang#160427 (comment) (3h 6m) r? @Mark-Simulacrum
…lacrum Run try builds on EC2 by default This PR switches try builds to EC2 instances by default, while still giving us the option to do a try build on codebuild. x64 Linux auto jobs are still using CodeBuild, for now. This script can be used to test the configuration of the generated CI jobs locally: ```bash #!/bin/bash #export GITHUB_EVENT_NAME=pull_request #export GITHUB_REF=refs/heads/pr/1 export GITHUB_EVENT_NAME=push export GITHUB_REF=refs/heads/automation/bors/try #export GITHUB_REF=refs/heads/automation/bors/auto #export COMMIT_MESSAGE="try-job: dist-x86_64-linux-quick" export COMMIT_MESSAGE="msg" export GITHUB_RUN_ID=123 export GITHUB_RUN_ATTEMPT=1 cargo run --manifest-path src/ci/citool/Cargo.toml calculate-job-matrix ``` CI runs: - `@bors try` - rust-lang#160427 (comment) (59m) - `@bors try jobs=dist-x86_64-linux-quick`: rust-lang#160427 (comment) (1h 32m) - `@bors try jobs=dist-x86_64-linux-codebuild`: rust-lang#160427 (comment) (3h 6m) - `@bors try jobs=dist-x86_64-linux`: rust-lang#160427 (comment) (3h 6m) r? @Mark-Simulacrum
Rollup of 28 pull requests Successful merges: - #153749 (Account for ownership mismatch on argument that doesn't meet bound) - #159130 (a bit optimize four-digit chunks in integer formatting) - #159326 (Deny multiple EII impls on a single item) - #159535 (Optimize slice::contains for bytewise types) - #159595 (Promote loongarch32-unknown-none* to Tier 2) - #160184 (Add -Zinstrument-mcount={fentry-nop-record,fentry-record}) - #160320 (point at trait definition when it is used as a derive macro) - #160369 (When suggesting method names, prefer *exact* doc aliases over similar names) - #160406 (`DepKind` cleanups) - #160424 (Use `thread::available_parallelism` as the default limit for backend parallelism) - #159303 (Fix ICE for direct inline const generic defaults) - #159977 (Add regression test for bool indexing codegen) - #160011 (remove InterpError::map_err_info) - #160165 (reject `...` without pattern post-expansion) - #160172 (tests: Enable `feature(stmt_expr_attributes)` in `2229_closure_analysis` tests) - #160295 (Fix rustdoc ICE when checking if a generic arg can be elided) - #160305 (Linkify C-SKY targets in `platform-support.md`) - #160314 (fix borrowck ICE for consts with fn pointer type) - #160322 (ElaborateBoxDeref: remove unnecessary projection) - #160338 (Add regression test for supertrait associated type normalization through dyn) - #160340 (Add regression test for unused_parens on contract clauses) - #160371 (Add doc aliases for transpositions `read_exact_buf` and `read_exact_buf_at`) - #160384 (Add PR body notes for Cargo lock file maintenance) - #160412 (Move duplicate-names check for #[rustc_must_implement_one_of] to attribute parser) - #160427 (Run try builds on EC2 by default) - #160435 (bump tracing-tree) - #160449 (Fix lookup of object files) - #160477 (Update the tracking issue for `borrowed_buf_init`)
Rollup of 28 pull requests Successful merges: - #153749 (Account for ownership mismatch on argument that doesn't meet bound) - #159130 (a bit optimize four-digit chunks in integer formatting) - #159326 (Deny multiple EII impls on a single item) - #159535 (Optimize slice::contains for bytewise types) - #159595 (Promote loongarch32-unknown-none* to Tier 2) - #160184 (Add -Zinstrument-mcount={fentry-nop-record,fentry-record}) - #160320 (point at trait definition when it is used as a derive macro) - #160369 (When suggesting method names, prefer *exact* doc aliases over similar names) - #160406 (`DepKind` cleanups) - #160424 (Use `thread::available_parallelism` as the default limit for backend parallelism) - #159303 (Fix ICE for direct inline const generic defaults) - #159977 (Add regression test for bool indexing codegen) - #160011 (remove InterpError::map_err_info) - #160165 (reject `...` without pattern post-expansion) - #160172 (tests: Enable `feature(stmt_expr_attributes)` in `2229_closure_analysis` tests) - #160295 (Fix rustdoc ICE when checking if a generic arg can be elided) - #160305 (Linkify C-SKY targets in `platform-support.md`) - #160314 (fix borrowck ICE for consts with fn pointer type) - #160322 (ElaborateBoxDeref: remove unnecessary projection) - #160338 (Add regression test for supertrait associated type normalization through dyn) - #160340 (Add regression test for unused_parens on contract clauses) - #160371 (Add doc aliases for transpositions `read_exact_buf` and `read_exact_buf_at`) - #160384 (Add PR body notes for Cargo lock file maintenance) - #160412 (Move duplicate-names check for #[rustc_must_implement_one_of] to attribute parser) - #160427 (Run try builds on EC2 by default) - #160435 (bump tracing-tree) - #160449 (Fix lookup of object files) - #160477 (Update the tracking issue for `borrowed_buf_init`)
Rollup of 28 pull requests Successful merges: - #153749 (Account for ownership mismatch on argument that doesn't meet bound) - #159130 (a bit optimize four-digit chunks in integer formatting) - #159326 (Deny multiple EII impls on a single item) - #159535 (Optimize slice::contains for bytewise types) - #159595 (Promote loongarch32-unknown-none* to Tier 2) - #160184 (Add -Zinstrument-mcount={fentry-nop-record,fentry-record}) - #160320 (point at trait definition when it is used as a derive macro) - #160369 (When suggesting method names, prefer *exact* doc aliases over similar names) - #160406 (`DepKind` cleanups) - #160424 (Use `thread::available_parallelism` as the default limit for backend parallelism) - #159303 (Fix ICE for direct inline const generic defaults) - #159977 (Add regression test for bool indexing codegen) - #160011 (remove InterpError::map_err_info) - #160165 (reject `...` without pattern post-expansion) - #160172 (tests: Enable `feature(stmt_expr_attributes)` in `2229_closure_analysis` tests) - #160295 (Fix rustdoc ICE when checking if a generic arg can be elided) - #160305 (Linkify C-SKY targets in `platform-support.md`) - #160314 (fix borrowck ICE for consts with fn pointer type) - #160322 (ElaborateBoxDeref: remove unnecessary projection) - #160338 (Add regression test for supertrait associated type normalization through dyn) - #160340 (Add regression test for unused_parens on contract clauses) - #160371 (Add doc aliases for transpositions `read_exact_buf` and `read_exact_buf_at`) - #160384 (Add PR body notes for Cargo lock file maintenance) - #160412 (Move duplicate-names check for #[rustc_must_implement_one_of] to attribute parser) - #160427 (Run try builds on EC2 by default) - #160435 (bump tracing-tree) - #160449 (Fix lookup of object files) - #160477 (Update the tracking issue for `borrowed_buf_init`)
Rollup of 29 pull requests Successful merges: - #153749 (Account for ownership mismatch on argument that doesn't meet bound) - #159130 (a bit optimize four-digit chunks in integer formatting) - #159326 (Deny multiple EII impls on a single item) - #159535 (Optimize slice::contains for bytewise types) - #159595 (Promote loongarch32-unknown-none* to Tier 2) - #160184 (Add -Zinstrument-mcount={fentry-nop-record,fentry-record}) - #160320 (point at trait definition when it is used as a derive macro) - #160369 (When suggesting method names, prefer *exact* doc aliases over similar names) - #160406 (`DepKind` cleanups) - #160424 (Use `thread::available_parallelism` as the default limit for backend parallelism) - #160434 (Avoid Docker push when the image did not change) - #159303 (Fix ICE for direct inline const generic defaults) - #159977 (Add regression test for bool indexing codegen) - #160011 (remove InterpError::map_err_info) - #160165 (reject `...` without pattern post-expansion) - #160172 (tests: Enable `feature(stmt_expr_attributes)` in `2229_closure_analysis` tests) - #160295 (Fix rustdoc ICE when checking if a generic arg can be elided) - #160305 (Linkify C-SKY targets in `platform-support.md`) - #160314 (fix borrowck ICE for consts with fn pointer type) - #160322 (ElaborateBoxDeref: remove unnecessary projection) - #160338 (Add regression test for supertrait associated type normalization through dyn) - #160340 (Add regression test for unused_parens on contract clauses) - #160371 (Add doc aliases for transpositions `read_exact_buf` and `read_exact_buf_at`) - #160384 (Add PR body notes for Cargo lock file maintenance) - #160412 (Move duplicate-names check for #[rustc_must_implement_one_of] to attribute parser) - #160427 (Run try builds on EC2 by default) - #160435 (bump tracing-tree) - #160449 (Fix lookup of object files) - #160477 (Update the tracking issue for `borrowed_buf_init`)
Rollup merge of #160427 - Kobzol:try-builds-ec2, r=Mark-Simulacrum Run try builds on EC2 by default This PR switches try builds to EC2 instances by default, while still giving us the option to do a try build on codebuild. x64 Linux auto jobs are still using CodeBuild, for now. This script can be used to test the configuration of the generated CI jobs locally: ```bash #!/bin/bash #export GITHUB_EVENT_NAME=pull_request #export GITHUB_REF=refs/heads/pr/1 export GITHUB_EVENT_NAME=push export GITHUB_REF=refs/heads/automation/bors/try #export GITHUB_REF=refs/heads/automation/bors/auto #export COMMIT_MESSAGE="try-job: dist-x86_64-linux-quick" export COMMIT_MESSAGE="msg" export GITHUB_RUN_ID=123 export GITHUB_RUN_ATTEMPT=1 cargo run --manifest-path src/ci/citool/Cargo.toml calculate-job-matrix ``` CI runs: - `@bors try` - #160427 (comment) (59m) - `@bors try jobs=dist-x86_64-linux-quick`: #160427 (comment) (1h 32m) - `@bors try jobs=dist-x86_64-linux-codebuild`: #160427 (comment) (3h 6m) - `@bors try jobs=dist-x86_64-linux`: #160427 (comment) (3h 6m) r? @Mark-Simulacrum
Run try builds on EC2 by default This PR switches try builds to EC2 instances by default, while still giving us the option to do a try build on codebuild. x64 Linux auto jobs are still using CodeBuild, for now. This script can be used to test the configuration of the generated CI jobs locally: ```bash #!/bin/bash #export GITHUB_EVENT_NAME=pull_request #export GITHUB_REF=refs/heads/pr/1 export GITHUB_EVENT_NAME=push export GITHUB_REF=refs/heads/automation/bors/try #export GITHUB_REF=refs/heads/automation/bors/auto #export COMMIT_MESSAGE="try-job: dist-x86_64-linux-quick" export COMMIT_MESSAGE="msg" export GITHUB_RUN_ID=123 export GITHUB_RUN_ATTEMPT=1 cargo run --manifest-path src/ci/citool/Cargo.toml calculate-job-matrix ``` CI runs: - `@bors try` - rust-lang/rust#160427 (comment) (59m) - `@bors try jobs=dist-x86_64-linux-quick`: rust-lang/rust#160427 (comment) (1h 32m) - `@bors try jobs=dist-x86_64-linux-codebuild`: rust-lang/rust#160427 (comment) (3h 6m) - `@bors try jobs=dist-x86_64-linux`: rust-lang/rust#160427 (comment) (3h 6m) r? @Mark-Simulacrum
Rollup of 29 pull requests Successful merges: - rust-lang/rust#153749 (Account for ownership mismatch on argument that doesn't meet bound) - rust-lang/rust#159130 (a bit optimize four-digit chunks in integer formatting) - rust-lang/rust#159326 (Deny multiple EII impls on a single item) - rust-lang/rust#159535 (Optimize slice::contains for bytewise types) - rust-lang/rust#159595 (Promote loongarch32-unknown-none* to Tier 2) - rust-lang/rust#160184 (Add -Zinstrument-mcount={fentry-nop-record,fentry-record}) - rust-lang/rust#160320 (point at trait definition when it is used as a derive macro) - rust-lang/rust#160369 (When suggesting method names, prefer *exact* doc aliases over similar names) - rust-lang/rust#160406 (`DepKind` cleanups) - rust-lang/rust#160424 (Use `thread::available_parallelism` as the default limit for backend parallelism) - rust-lang/rust#160434 (Avoid Docker push when the image did not change) - rust-lang/rust#159303 (Fix ICE for direct inline const generic defaults) - rust-lang/rust#159977 (Add regression test for bool indexing codegen) - rust-lang/rust#160011 (remove InterpError::map_err_info) - rust-lang/rust#160165 (reject `...` without pattern post-expansion) - rust-lang/rust#160172 (tests: Enable `feature(stmt_expr_attributes)` in `2229_closure_analysis` tests) - rust-lang/rust#160295 (Fix rustdoc ICE when checking if a generic arg can be elided) - rust-lang/rust#160305 (Linkify C-SKY targets in `platform-support.md`) - rust-lang/rust#160314 (fix borrowck ICE for consts with fn pointer type) - rust-lang/rust#160322 (ElaborateBoxDeref: remove unnecessary projection) - rust-lang/rust#160338 (Add regression test for supertrait associated type normalization through dyn) - rust-lang/rust#160340 (Add regression test for unused_parens on contract clauses) - rust-lang/rust#160371 (Add doc aliases for transpositions `read_exact_buf` and `read_exact_buf_at`) - rust-lang/rust#160384 (Add PR body notes for Cargo lock file maintenance) - rust-lang/rust#160412 (Move duplicate-names check for #[rustc_must_implement_one_of] to attribute parser) - rust-lang/rust#160427 (Run try builds on EC2 by default) - rust-lang/rust#160435 (bump tracing-tree) - rust-lang/rust#160449 (Fix lookup of object files) - rust-lang/rust#160477 (Update the tracking issue for `borrowed_buf_init`)
View all comments
This PR switches try builds to EC2 instances by default, while still giving us the option to do a try build on codebuild.
x64 Linux auto jobs are still using CodeBuild, for now.
This script can be used to test the configuration of the generated CI jobs locally:
CI runs:
@bors try- Run try builds on EC2 by default #160427 (comment) (59m)@bors try jobs=dist-x86_64-linux-quick: Run try builds on EC2 by default #160427 (comment) (1h 32m)@bors try jobs=dist-x86_64-linux-codebuild: Run try builds on EC2 by default #160427 (comment) (3h 6m)@bors try jobs=dist-x86_64-linux: Run try builds on EC2 by default #160427 (comment) (3h 6m)r? @Mark-Simulacrum