Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk` by joshtriplett · Pull Request #160362 · rust-lang/rust

joshtriplett · 2026-08-01T23:43:03Z

rustc_privacy pulls in all of rustc_ty_utils, but only wants SpannedTypeVisitor and walk_types. Move those to a small rustc_ty_walk crate.

This allows rustc_privacy to start building much sooner.

rustbot · 2026-08-01T23:43:06Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

rustbot · 2026-08-01T23:43:08Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 18 candidates

mejrs · 2026-08-02T00:44:12Z

You need to bless bootstrap, see https://github.com/rust-lang/rust/blob/main/src/bootstrap/README.md#testing

joshtriplett · 2026-08-02T07:55:03Z

@rustbot ready

mejrs · 2026-08-02T12:49:12Z

I think we should consider splitting up rustc_ty_utils (perhaps poorly named if it's just providing queries now?) further:

crate A: Queries that need rustc_trait_selection
crate B: Queries that only need rustc_middle (or perhaps rustc_infer - haven't thought about what the best split is here)
crate C: What this pr calls rustc_ty_walk - the actual util stuff shared between A and B and other crates. Maybe there's also stuff currently defined in rustc_middle that could be moved here.

joshtriplett · 2026-08-02T18:21:16Z

@mejrs That sounds reasonable. But also, I'm a big fan of incremental steps; we can always split/merge crates further after this. :)

mejrs · 2026-08-02T20:30:27Z

@mejrs That sounds reasonable. But also, I'm a big fan of incremental steps; we can always split/merge crates further after this. :)

Yes! Please keep this PR small, I'm not suggesting it is done right here and now (hence, just "considering" 🙂).

`rustc_privacy` pulls in all of `rustc_ty_utils`, but only wants `SpannedTypeVisitor` and `walk_types`. Move those to a small `rustc_ty_walk` crate. This allows `rustc_privacy` to start building much sooner.

rustbot · 2026-08-04T04:49:25Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

joshtriplett · 2026-08-04T04:49:30Z

Rebased.

fee1-dead · 2026-08-04T20:17:46Z

Thanks!

@bors r+ rollup

rust-bors · 2026-08-04T20:17:49Z

📌 Commit 0f80d01 has been approved by fee1-dead

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: manually handling queue due to backlog

…-dead Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk` `rustc_privacy` pulls in all of `rustc_ty_utils`, but only wants `SpannedTypeVisitor` and `walk_types`. Move those to a small `rustc_ty_walk` crate. This allows `rustc_privacy` to start building much sooner.

…uwer Rollup of 22 pull requests Successful merges: - #158147 (std: fix stack buffer overflow in Windows junction_point) - #159784 (Hint that memchr returns an in-bounds index) - #160130 (Select cache values to verify by key fingerprint, not value fingerprint) - #160343 (Rename `OutlivesPredicate` to `OutlivesClause`) - #160360 (Remove rustc_middle dependency on rustc_hir_pretty) - #160387 (rustc_codegen_ssa: Correctly apply the static `--jobs-backend` limit to backend parallelism) - #160422 (move mir-opt miri tests to CI logic) - #160444 (Avoid resolving path keywords outside `TypeNS`) - #160510 (Resolver: (un)tracked borrows for `CmRefCell` made safe my unsafe speculative flag) - #155424 ([blocked] Link to proposed LLM policy in CONTRIBUTING and pull request template) - #158726 (std: move futex implementations into sys::sync::futex) - #159225 (Split IncrCompSession out of Session) - #159820 (Make the `rustc_unsafe_specialization_marker` attribute actually `unsafe`) - #160198 (Rework `smallest_range_containing` to handle duplicates) - #160362 (Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`) - #160390 (autodiff: Handle slice-tailed DSTs in type trees) - #160420 (Suggest `cast_signed()` for overflowing signed integer literals) - #160520 (Add some tests for specialization) - #160522 (fix(bootstrap): Normalize the names of proc macro dependency crates) - #160531 (docs: fix typo in AllowExprMetavar comment) - #160538 (Update expect messages in tcp.rs doc examples to follow the style guide) - #160548 (bootstrap: Register `coverage-map` and `coverage-run` aliases via a separate step)

…-dead Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk` `rustc_privacy` pulls in all of `rustc_ty_utils`, but only wants `SpannedTypeVisitor` and `walk_types`. Move those to a small `rustc_ty_walk` crate. This allows `rustc_privacy` to start building much sooner.

…uwer Rollup of 25 pull requests Successful merges: - #154585 (treat no_mangle_generic_items as hard error instead of lint warning) - #158147 (std: fix stack buffer overflow in Windows junction_point) - #160130 (Select cache values to verify by key fingerprint, not value fingerprint) - #160343 (Rename `OutlivesPredicate` to `OutlivesClause`) - #160360 (Remove rustc_middle dependency on rustc_hir_pretty) - #160387 (rustc_codegen_ssa: Correctly apply the static `--jobs-backend` limit to backend parallelism) - #160422 (move mir-opt miri tests to CI logic) - #160444 (Avoid resolving path keywords outside `TypeNS`) - #160510 (Resolver: (un)tracked borrows for `CmRefCell` made safe my unsafe speculative flag) - #155424 ([blocked] Link to proposed LLM policy in CONTRIBUTING and pull request template) - #158726 (std: move futex implementations into sys::sync::futex) - #158762 (Emit thumb code on VEX V5) - #159225 (Split IncrCompSession out of Session) - #159820 (Make the `rustc_unsafe_specialization_marker` attribute actually `unsafe`) - #160198 (Rework `smallest_range_containing` to handle duplicates) - #160362 (Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`) - #160390 (autodiff: Handle slice-tailed DSTs in type trees) - #160420 (Suggest `cast_signed()` for overflowing signed integer literals) - #160516 (Add regression test for HRTB projection in closure) - #160520 (Add some tests for specialization) - #160522 (fix(bootstrap): Normalize the names of proc macro dependency crates) - #160523 (Add regression test for opaque type) - #160531 (docs: fix typo in AllowExprMetavar comment) - #160538 (Update expect messages in tcp.rs doc examples to follow the style guide) - #160548 (bootstrap: Register `coverage-map` and `coverage-run` aliases via a separate step)

…-dead Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk` `rustc_privacy` pulls in all of `rustc_ty_utils`, but only wants `SpannedTypeVisitor` and `walk_types`. Move those to a small `rustc_ty_walk` crate. This allows `rustc_privacy` to start building much sooner.

…uwer Rollup of 25 pull requests Successful merges: - #158147 (std: fix stack buffer overflow in Windows junction_point) - #160130 (Select cache values to verify by key fingerprint, not value fingerprint) - #160343 (Rename `OutlivesPredicate` to `OutlivesClause`) - #160360 (Remove rustc_middle dependency on rustc_hir_pretty) - #160387 (rustc_codegen_ssa: Correctly apply the static `--jobs-backend` limit to backend parallelism) - #160422 (move mir-opt miri tests to CI logic) - #160444 (Avoid resolving path keywords outside `TypeNS`) - #160510 (Resolver: (un)tracked borrows for `CmRefCell` made safe by unsafe speculative flag) - #155424 ([blocked] Link to proposed LLM policy in CONTRIBUTING and pull request template) - #158726 (std: move futex implementations into sys::sync::futex) - #158762 (Emit thumb code on VEX V5) - #159225 (Split IncrCompSession out of Session) - #159820 (Make the `rustc_unsafe_specialization_marker` attribute actually `unsafe`) - #160198 (Rework `smallest_range_containing` to handle duplicates) - #160362 (Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`) - #160390 (autodiff: Handle slice-tailed DSTs in type trees) - #160420 (Suggest `cast_signed()` for overflowing signed integer literals) - #160501 (Add bootstrap CLI snapshot test for testing miri) - #160516 (Add regression test for HRTB projection in closure) - #160520 (Add some tests for specialization) - #160522 (fix(bootstrap): Normalize the names of proc macro dependency crates) - #160523 (Add regression test for opaque type) - #160531 (docs: fix typo in AllowExprMetavar comment) - #160538 (Update expect messages in tcp.rs doc examples to follow the style guide) - #160548 (bootstrap: Register `coverage-map` and `coverage-run` aliases via a separate step)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 1, 2026

rustbot assigned fee1-dead Aug 1, 2026

This comment has been minimized.

Sign in to view

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 2, 2026

fee1-dead requested changes Aug 2, 2026

View reviewed changes

Comment thread compiler/rustc_ty_walk/src/lib.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 2, 2026

joshtriplett requested a review from fee1-dead August 2, 2026 19:43

This comment has been minimized.

Sign in to view

joshtriplett added 2 commits August 3, 2026 21:47

Split SpannedTypeVisitor into its own crate, rustc_ty_walk

82317b3

`rustc_privacy` pulls in all of `rustc_ty_utils`, but only wants `SpannedTypeVisitor` and `walk_types`. Move those to a small `rustc_ty_walk` crate. This allows `rustc_privacy` to start building much sooner.

Bless bootstrap tests for new rustc_ty_walk crate

0f80d01

joshtriplett force-pushed the ty-walk-crate branch from ec239d5 to 0f80d01 Compare August 4, 2026 04:49

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2026

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 11 pull requests #160547

Closed

jhpratt mentioned this pull request Aug 5, 2026

Rollup of 16 pull requests #160549

Closed

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 22 pull requests #160554

Closed

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 25 pull requests #160557

Closed

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 25 pull requests #160559

Open

Navigation Menu

Uh oh!

Uh oh!

Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk` - #160362

Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`#160362
joshtriplett wants to merge 2 commits into
rust-lang:mainfrom
joshtriplett:ty-walk-crate

joshtriplett commented Aug 1, 2026

Uh oh!

rustbot commented Aug 1, 2026

Uh oh!

rustbot commented Aug 1, 2026

Uh oh!

This comment has been minimized.

mejrs commented Aug 2, 2026

Uh oh!

Uh oh!

joshtriplett commented Aug 2, 2026

Uh oh!

mejrs commented Aug 2, 2026

Uh oh!

joshtriplett commented Aug 2, 2026

Uh oh!

mejrs commented Aug 2, 2026

Uh oh!

This comment has been minimized.

rustbot commented Aug 4, 2026

Uh oh!

joshtriplett commented Aug 4, 2026

Uh oh!

fee1-dead commented Aug 4, 2026

Uh oh!

rust-bors Bot commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

joshtriplett commented Aug 1, 2026

Uh oh!

rustbot commented Aug 1, 2026

Uh oh!

rustbot commented Aug 1, 2026

Uh oh!

This comment has been minimized.

mejrs commented Aug 2, 2026

Uh oh!

Uh oh!

joshtriplett commented Aug 2, 2026

Uh oh!

mejrs commented Aug 2, 2026

Uh oh!

joshtriplett commented Aug 2, 2026

Uh oh!

mejrs commented Aug 2, 2026

Uh oh!

This comment has been minimized.

rustbot commented Aug 4, 2026

Uh oh!

joshtriplett commented Aug 4, 2026

Uh oh!

fee1-dead commented Aug 4, 2026

Uh oh!

rust-bors Bot commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants