Expand checks for register_tool - #160145
Merged
Merged
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
mejrs
reviewed
Jul 30, 2026
Contributor
There was a problem hiding this comment.
Can you update the PR description to specify precisely what functionality is implemented?
Both for myself, so I can verify the implementation matches intent, and to leave a summary for others, so they can read it while reviewing the state of the feature or writing reference material for example. This applies especially if/when we diverge from the RFC.
The RFC specifies "tools must be a single ident", this PR implements "must be a valid identifier". That best matches the intent of the RFC, so lets go ahead with that. (Another option would be to limit to ascii but iirc there is no good reason to be that restrictive)
Contributor
There was a problem hiding this comment.
Can you also add such a test using -Zcrate-attr=register_tool(..) -Zallow(duplicate_tools) (whatever the precise syntax is) with a crate level attribute introducing the same tool?
Forbid super/crate/self/Self to be used in register_tool. Also, add test for raw identifier and unicode identifiers.
This adds back the previously existing duplicate tool error, but as a suppressable lint.
Member
Author
I have nothing to add except those already in the commit message. I just added the commit message to the PR description and hopefully that's enough.
Added a line to test unicode too. @rustbot ready |
Contributor
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 1, 2026
Expand checks for register_tool Follow up to rust-lang#158038 (review) and rust-lang#158038 (comment) * Add tool-attribute test to ensure tools are not preserved across crate * Reject invalid identifiers (super/self/Self/crate) in register_tool * Add lint for duplicate tools r? @mejrs
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 1, 2026
Expand checks for register_tool Follow up to rust-lang#158038 (review) and rust-lang#158038 (comment) * Add tool-attribute test to ensure tools are not preserved across crate * Reject invalid identifiers (super/self/Self/crate) in register_tool * Add lint for duplicate tools r? @mejrs
This was referenced Aug 1, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 1, 2026
Rollup of 14 pull requests Successful merges: - #159245 (Emit retags in codegen to support BorrowSanitizer (part 5)) - #159864 (Report "capacity overflow" for oversized Rc<[T]>/Arc<[T]>) - #160079 (make atomic operations const) - #160124 (Structurally prevent zero-count `BackendRepr::SimdVector`s) - #160162 (Make `#[fundamental]` only apply to the first argument of `Box`) - #160210 (Remove an outdated FIXME) - #160282 (Improve diagnostic for patterns in function pointer types) - #157928 (Eagerly fetch typeck results when linting) - #159672 (Improve suggestions when multiples tuples implement the same trait) - #159861 (Add documentation for the `non_exhaustive` attribute) - #159907 (Fix `hidden_glob_reexports` in `rustc_ast`) - #159998 (Align expect messages with guidance) - #160145 (Expand checks for register_tool) - #160307 (Update `minifier` version to `0.4.0`)
rust-timer
added a commit
that referenced
this pull request
Aug 1, 2026
Rollup merge of #160145 - nbdd0121:register_tool, r=mejrs Expand checks for register_tool Follow up to #158038 (review) and #158038 (comment) * Add tool-attribute test to ensure tools are not preserved across crate * Reject invalid identifiers (super/self/Self/crate) in register_tool * Add lint for duplicate tools r? @mejrs
8 tasks
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Aug 2, 2026
Rollup of 14 pull requests Successful merges: - rust-lang/rust#159245 (Emit retags in codegen to support BorrowSanitizer (part 5)) - rust-lang/rust#159864 (Report "capacity overflow" for oversized Rc<[T]>/Arc<[T]>) - rust-lang/rust#160079 (make atomic operations const) - rust-lang/rust#160124 (Structurally prevent zero-count `BackendRepr::SimdVector`s) - rust-lang/rust#160162 (Make `#[fundamental]` only apply to the first argument of `Box`) - rust-lang/rust#160210 (Remove an outdated FIXME) - rust-lang/rust#160282 (Improve diagnostic for patterns in function pointer types) - rust-lang/rust#157928 (Eagerly fetch typeck results when linting) - rust-lang/rust#159672 (Improve suggestions when multiples tuples implement the same trait) - rust-lang/rust#159861 (Add documentation for the `non_exhaustive` attribute) - rust-lang/rust#159907 (Fix `hidden_glob_reexports` in `rustc_ast`) - rust-lang/rust#159998 (Align expect messages with guidance) - rust-lang/rust#160145 (Expand checks for register_tool) - rust-lang/rust#160307 (Update `minifier` version to `0.4.0`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #158038 (review) and #158038 (comment)
r? @mejrs