Align expect messages with guidance by pluiee · Pull Request #159998 · rust-lang/rust

pluiee · 2026-07-27T08:29:50Z

Changed 3 expect messages and some relevant comments in library/core/src/result.rs and library/core/src/primitive_docs.rs
I intentionally left the below snippet unchanged in library/core/src/result.rs.
The example is quite minimal and focuses on showing the panic output format, so I thought it was better to keep the message short and simple.

    /// # Panics
    ///
    /// Panics if the value is an [`Err`], with a panic message including the
    /// passed message, and the content of the [`Err`].
    ///
    ///
    /// # Examples
    ///
    /// ```should_panic
    /// let x: Result<u32, &str> = Err("emergency failure");
    /// x.expect("Testing expect"); // panics with `Testing expect: emergency failure`
    /// ```

r? @fee1-dead

rustbot · 2026-07-27T08:29:55Z

fee1-dead is currently at their maximum review capacity.
They may take a while to respond.

mejrs · 2026-07-27T13:31:31Z

 //!
 //! let mut file = File::create("valuable_data.txt").unwrap();
-//! file.write_all(b"important message").expect("failed to write message");
+//! file.write_all(b"important message").expect("newly created file should be writable");


This is far too specific, you can fail a write for other reasons.

View changes since the review

Changed the message to "writing to the file should succeed". I'm a bit worried that it states the obvious without adding extra context, but since it's just a generic example, I think this should be enough.

mejrs · 2026-07-27T13:31:33Z

 /// ```ignore (hypothetical-example)
 /// loop {
-///     let (client, request) = get_request().expect("disconnected");
+///     let (client, request) = get_request().expect("server should stay connected while accepting requests");


This line is long enough that the example will get a horizontal scrollbar.
Can you make it shorter?

View changes since the review

Shortened to "server should stay connected"

rustbot · 2026-07-27T13:31:57Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

pluiee · 2026-07-28T07:19:04Z

@rustbot ready

fee1-dead · 2026-07-31T20:25:37Z

@bors r+ rollup

rust-bors · 2026-07-31T20:25:41Z

📌 Commit e4b881f has been approved by fee1-dead

It is now in the queue for this repository.

@fee1-dead

Align expect messages with guidance Issue: rust-lang#159751 - Changed 3 `expect` messages and some relevant comments in `library/core/src/result.rs` and `library/core/src/primitive_docs.rs` - I intentionally left the below snippet unchanged in `library/core/src/result.rs`. The example is quite minimal and focuses on showing the panic output format, so I thought it was better to keep the message short and simple. ``` /// # Panics /// /// Panics if the value is an [`Err`], with a panic message including the /// passed message, and the content of the [`Err`]. /// /// /// # Examples /// /// ```should_panic /// let x: Result<u32, &str> = Err("emergency failure"); /// x.expect("Testing expect"); // panics with `Testing expect: emergency failure` /// ``` ``` r? @fee1-dead

@fee1-dead

Align expect messages with guidance Issue: rust-lang#159751 - Changed 3 `expect` messages and some relevant comments in `library/core/src/result.rs` and `library/core/src/primitive_docs.rs` - I intentionally left the below snippet unchanged in `library/core/src/result.rs`. The example is quite minimal and focuses on showing the panic output format, so I thought it was better to keep the message short and simple. ``` /// # Panics /// /// Panics if the value is an [`Err`], with a panic message including the /// passed message, and the content of the [`Err`]. /// /// /// # Examples /// /// ```should_panic /// let x: Result<u32, &str> = Err("emergency failure"); /// x.expect("Testing expect"); // panics with `Testing expect: emergency failure` /// ``` ``` r? @fee1-dead

Rollup of 14 pull requests Successful merges: - #159245 (Emit retags in codegen to support BorrowSanitizer (part 5)) - #159864 (Report "capacity overflow" for oversized Rc<[T]>/Arc<[T]>) - #160079 (make atomic operations const) - #160124 (Structurally prevent zero-count `BackendRepr::SimdVector`s) - #160162 (Make `#[fundamental]` only apply to the first argument of `Box`) - #160210 (Remove an outdated FIXME) - #160282 (Improve diagnostic for patterns in function pointer types) - #157928 (Eagerly fetch typeck results when linting) - #159672 (Improve suggestions when multiples tuples implement the same trait) - #159861 (Add documentation for the `non_exhaustive` attribute) - #159907 (Fix `hidden_glob_reexports` in `rustc_ast`) - #159998 (Align expect messages with guidance) - #160145 (Expand checks for register_tool) - #160307 (Update `minifier` version to `0.4.0`)

@fee1-dead

Rollup merge of #159998 - pluiee:pluiee/expect-msg, r=fee1-dead Align expect messages with guidance Issue: #159751 - Changed 3 `expect` messages and some relevant comments in `library/core/src/result.rs` and `library/core/src/primitive_docs.rs` - I intentionally left the below snippet unchanged in `library/core/src/result.rs`. The example is quite minimal and focuses on showing the panic output format, so I thought it was better to keep the message short and simple. ``` /// # Panics /// /// Panics if the value is an [`Err`], with a panic message including the /// passed message, and the content of the [`Err`]. /// /// /// # Examples /// /// ```should_panic /// let x: Result<u32, &str> = Err("emergency failure"); /// x.expect("Testing expect"); // panics with `Testing expect: emergency failure` /// ``` ``` r? @fee1-dead

Rollup of 14 pull requests Successful merges: - rust-lang/rust#159245 (Emit retags in codegen to support BorrowSanitizer (part 5)) - rust-lang/rust#159864 (Report "capacity overflow" for oversized Rc<[T]>/Arc<[T]>) - rust-lang/rust#160079 (make atomic operations const) - rust-lang/rust#160124 (Structurally prevent zero-count `BackendRepr::SimdVector`s) - rust-lang/rust#160162 (Make `#[fundamental]` only apply to the first argument of `Box`) - rust-lang/rust#160210 (Remove an outdated FIXME) - rust-lang/rust#160282 (Improve diagnostic for patterns in function pointer types) - rust-lang/rust#157928 (Eagerly fetch typeck results when linting) - rust-lang/rust#159672 (Improve suggestions when multiples tuples implement the same trait) - rust-lang/rust#159861 (Add documentation for the `non_exhaustive` attribute) - rust-lang/rust#159907 (Fix `hidden_glob_reexports` in `rustc_ast`) - rust-lang/rust#159998 (Align expect messages with guidance) - rust-lang/rust#160145 (Expand checks for register_tool) - rust-lang/rust#160307 (Update `minifier` version to `0.4.0`)

rustbot assigned fee1-dead Jul 27, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 27, 2026

mejrs requested changes Jul 27, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2026

Align expect messages with guidance

e4b881f

pluiee force-pushed the pluiee/expect-msg branch from 6292ad3 to e4b881f Compare July 28, 2026 07:15

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 28, 2026

pluiee requested a review from mejrs July 28, 2026 07:20

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2026

jhpratt mentioned this pull request Aug 1, 2026

Rollup of 16 pull requests #160308

Closed

This was referenced Aug 1, 2026

Rollup of 15 pull requests #160309

Closed

Rollup of 14 pull requests #160310

Merged

rust-bors Bot merged commit ab91b74 into rust-lang:main Aug 1, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Align expect messages with guidance - #159998

Align expect messages with guidance#159998
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
pluiee:pluiee/expect-msg

pluiee commented Jul 27, 2026

Uh oh!

rustbot commented Jul 27, 2026

Uh oh!

mejrs Jul 27, 2026 •

edited by rustbot

Loading

Uh oh!

pluiee Jul 28, 2026

Uh oh!

mejrs Jul 27, 2026 •

edited by rustbot

Loading

Uh oh!

pluiee Jul 28, 2026

Uh oh!

rustbot commented Jul 27, 2026

Uh oh!

pluiee commented Jul 28, 2026

Uh oh!

fee1-dead commented Jul 31, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

pluiee commented Jul 27, 2026

Uh oh!

rustbot commented Jul 27, 2026

Uh oh!

mejrs Jul 27, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pluiee Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

mejrs Jul 27, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pluiee Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jul 27, 2026

Uh oh!

pluiee commented Jul 28, 2026

Uh oh!

fee1-dead commented Jul 31, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mejrs Jul 27, 2026 •

edited by rustbot

Loading

mejrs Jul 27, 2026 •

edited by rustbot

Loading