Never use identity comparison for Ruby objects.#97
Closed
headius wants to merge 1 commit intoruby:1-4-stablefrom
Closed
Never use identity comparison for Ruby objects.#97headius wants to merge 1 commit intoruby:1-4-stablefrom
headius wants to merge 1 commit intoruby:1-4-stablefrom
Conversation
Numeric objects in JRuby do not have guarantees of idempotence. In this code, many places used object equality to compare two Fixnum objects, a situation which is never guaranteed to work, and which is much more likely to fail when JRuby's cache of low-valued Fixnum objects is turned off as in jruby/jruby#5401. This patch removes all such object identity comparisons and replaces them with .equals calls.
Member
|
@headius Can you rebase from the current |
Member
|
I did rename |
Contributor
Author
|
Looks like I committed this myself? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 1.4-compatible version of #92. I need this in a racc release to fix jruby/jruby#5401 so I have created this PR to get consensus that this is ok to go in 1-4-stable branch.
Numeric objects in JRuby do not have guarantees of idempotence. In
this code, many places used object equality to compare two Fixnum
objects, a situation which is never guaranteed to work, and which
is much more likely to fail when JRuby's cache of low-valued
Fixnum objects is turned off as in jruby/jruby#5401. This patch
removes all such object identity comparisons and replaces them
with .equals calls.