Never use identity comparison for Ruby objects.#92
Merged
headius merged 1 commit intoruby:masterfrom Nov 19, 2018
Merged
Conversation
Numeric objects in JRuby do not have guarantees of idempotence. In this code, many places used object equality to compare two Fixnum objects, a situation which is never guaranteed to work, and which is much more likely to fail when JRuby's cache of low-valued Fixnum objects is turned off as in jruby/jruby#5401. This patch removes all such object identity comparisons and replaces them with .equals calls.
Contributor
Author
|
This was likely an oversight when I did the original port; MRI can afford to do direct comparisons of Fixnum objects since they are idempotent (and not really objects). |
Contributor
Author
|
This does not affect CI execution because it only fails in a very specific, experimental JRuby mode ( |
This was referenced Nov 19, 2018
Contributor
Author
|
I have tested that this fixes jruby/jruby#5401 and that it does not regress any tests. Work to get JRuby running in CI will continue in #93. |
This was referenced Nov 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric objects in JRuby do not have guarantees of idempotence. In
this code, many places used object equality to compare two Fixnum
objects, a situation which is never guaranteed to work, and which
is much more likely to fail when JRuby's cache of low-valued
Fixnum objects is turned off as in jruby/jruby#5401. This patch
removes all such object identity comparisons and replaces them
with .equals calls.