Merged
Conversation
launch/launch/launcher.py
Outdated
Member
There was a problem hiding this comment.
Should this timeout be parameterized?
launch/launch/launcher.py
Outdated
Member
There was a problem hiding this comment.
The (object) isn't required in Python3 for "new" style classes. Leaving it doesn't hurt though.
Member
Author
There was a problem hiding this comment.
We currently use it in 33 other places with the object and only in one location without. I would keep it for now but we can certainly remove it in all locations if everyone agrees.
…tead of silently pass, use tempfile instead of hardcoded files in /tmp, update description
414c73a to
abc9964
Compare
Member
Author
|
@wjwwood Thanks, I have address all your comments. |
Member
|
One more comment is that there are no headers in the files with copyright and license snippet. Other than that, lgtm. |
Member
|
Re-reviewed, +1 |
Contributor
|
lgtm |
Member
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And an example launch file.
Connects to ros2/ros2#4
@esteve @tfoote @wjwwood Please review.