Added Con[V]ex Hull and Shad[O]ws Rendering - #7
Merged
rohanpsingh merged 6 commits intoJun 19, 2022
Conversation
Owner
|
Hi @rohit-kumar-j This PR fails with the following:
Is it because I didn't merge PR #5 yet? |
Contributor
Author
|
Made the changes. It should work now. Sorry about that. Callbacks were not ready yet. |
rohanpsingh
reviewed
Jun 13, 2022
| self._transparent = False | ||
| self._contacts = False | ||
| self._joints = False | ||
| self._shadows = False |
Owner
There was a problem hiding this comment.
self._shadows = True
since shadows are ON by default
| self.vopt.flags[ | ||
| mujoco.mjtVisFlag.mjVIS_CONVEXHULL | ||
| ] = self._convex_hull_rendering | ||
| self._convex_hull_rendering = not self._convex_hull_rendering |
Owner
There was a problem hiding this comment.
This line should come before setting the vopt flags
Owner
There was a problem hiding this comment.
This is the correct order:
self._convex_hull_rendering = not self._convex_hull_rendering
self.vopt.flags[
mujoco.mjtVisFlag.mjVIS_CONVEXHULL
] = self._convex_hull_rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from deepmind/mujoco/discussions/336