Skip to content

Added joint, wireframe, COM, Inertia overlay - #3

Merged
rohanpsingh merged 3 commits into
rohanpsingh:mainfrom
rohit-kumar-j:main
May 13, 2022
Merged

Added joint, wireframe, COM, Inertia overlay#3
rohanpsingh merged 3 commits into
rohanpsingh:mainfrom
rohit-kumar-j:main

Conversation

@rohit-kumar-j

Copy link
Copy Markdown
Contributor

Joint overlay added with "J"

joint_overlay_gif

Joint overlay added with "J"
@rohit-kumar-j
rohit-kumar-j marked this pull request as ready for review May 12, 2022 20:40
Toggle wireframe rendering Key = "W"
@rohit-kumar-j

Copy link
Copy Markdown
Contributor Author

Added Wireframe rendering with "W"

wire_frame_rendering_mujoco

@rohit-kumar-j rohit-kumar-j changed the title Added joint overlay Added joint, wireframe overlay May 12, 2022
Toggle functionality with I and M
@rohit-kumar-j

Copy link
Copy Markdown
Contributor Author

COM:
com_rendering_mujoco

INERTIA:
inertia_rendering_mujoco

@rohanpsingh

Copy link
Copy Markdown
Owner

Looks good, thanks for the PR!

@rohanpsingh
rohanpsingh merged commit e2bbb71 into rohanpsingh:main May 13, 2022
@rohanpsingh

Copy link
Copy Markdown
Owner

Assuming, mjVIS_CONTACTFORCE was removed inadvertently, I'll add that line again manually.

@rohit-kumar-j

Copy link
Copy Markdown
Contributor Author

mjVIS_CONTACTFORCE was written twice, so I reduced it

@rohit-kumar-j

Copy link
Copy Markdown
Contributor Author

I wanted to add convex hull as well, but didn't really know how to work with the documentation in C. The mjVIS_CONVEXHULL is equal to 0. I saw the vopt.frame and tried the same but didn't work. Do you have any pointers to example python bindings examples like the Pybullet Quickstart Guide

@rohit-kumar-j rohit-kumar-j changed the title Added joint, wireframe overlay Added joint, wireframe, COM, Inertia overlay May 13, 2022
@rohanpsingh

Copy link
Copy Markdown
Owner

mjVIS_CONTACTFORCE was written twice, so I reduced it

The first line was for mjVIS_CONTACTPOINT followed by the line for mjVIS_CONTACTFORCE. Their purpose is different.

I wanted to add convex hull as well, but didn't really know how to work with the documentation in C.

Let me see if I can get it working.

@rohit-kumar-j

Copy link
Copy Markdown
Contributor Author

The first line was for mjVIS_CONTACTPOINT followed by the line for mjVIS_CONTACTFORCE. Their purpose is different.

Ah. I missed that

@rohit-kumar-j

Copy link
Copy Markdown
Contributor Author

PR #7 with Convex Hull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants