Make the time-entry dialog contract field a customer-scoped dropdown - #238
Merged
Conversation
The shared TimeEntryDialog rendered the contract (Vertrag) field as a free-text input, so it accepted arbitrary strings instead of the customer's actual contracts. Now that every time entry is edited through this dialog, the regression is visible everywhere. Swap the input for the shared ContractSelect, fed by useContracts(customer), which lists the customer's contracts (hiding invoiced ones but keeping the currently-selected value). Changing the customer clears the contract so a stale value from another customer can't linger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The shared
TimeEntryDialog(used to edit every clock/task time entry after #236) rendered the contract (Vertrag) field as a free-text<input>. It accepted arbitrary strings instead of the customer's actual contracts, and since all entries now edit through this dialog, the problem is visible everywhere.Fix
Swap the input for the shared
ContractSelect, fed byuseContracts(customer). It lists the selected customer's contracts (hiding invoiced ones, but keeping the currently-selected value so editing an existing entry never blanks it). Changing the customer clears the contract so a stale value from another customer can't linger.Acceptance
tsc+pnpm buildclean.