Edit every time entry through the shared modal, with notes preview/edit tabs - #236
Merged
Conversation
…it tabs Every clock/task time entry now opens the shared TimeEntryDialog to edit, instead of ad-hoc inline forms with differing field coverage: - Timer sidebar (ClockList): replaced its inline edit form. - Task-card entries (kanban ClockEntryRow): replaced the description+hours-only inline edit with the full editor. - Dashboard customer entries (DashboardView ClockEntryRow): replaced its inline edit form. - Clocks table (EntryRow): dropped double-click-to-edit; the pencil still opens the dialog. The dialog's notes field now uses MarkdownEditor (Preview/Write tabs, preview first) so notes render with clickable links in view mode and switch to a textarea to edit -- the view/edit behaviour that was missing. Quick actions (toggle invoiced, detach) are unchanged. Net: one modal, identical fields and behaviour across the sidebar, task cards, dashboard, clocks table, customer view and projects.
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Editing a clock/task time entry was inconsistent across the app. The Clocks table, customer view and projects already opened the shared
TimeEntryDialog, but the timer sidebar (ClockList), the entries under a task card (kanban/ClockEntryRow) and the dashboard customer entries (DashboardView) each had their own ad-hoc inline edit form with a different subset of fields (e.g. the task-card row could only edit description + hours). The dialog's notes field was also a plain textarea, so links in notes were not clickable.What changed
Every place a time entry appears now opens the same
TimeEntryDialog:clock/ClockList.tsx(timer sidebar) — removed the inline edit form; the pencil opens the dialog.kanban/ClockEntryRow.tsx(task-card entries) — removed the description+hours-only inline edit; opens the full dialog.dashboard/DashboardView.tsx(dashboard customer entries) — removed the inline edit form; opens the dialog.clock/EntryRow.tsx(Clocks table) — dropped double-click-to-edit; the pencil still opens the dialog.The dialog's notes field now uses the existing
MarkdownEditor(Preview/Write tabs, preview first), so notes render with clickable links in view mode and switch to a plain text box to edit — the view/edit behaviour that was missing.Quick actions (toggle invoiced, detach from task) are unchanged. Net −319 lines.
Acceptance
tscandpnpm buildpass.