Skip to content

Prevent error in destroyChart when chartInstance does not exist#453

Merged
jerairrest merged 2 commits into
reactchartjs:masterfrom
andreme:fix-destroychart
Jan 26, 2020
Merged

Prevent error in destroyChart when chartInstance does not exist#453
jerairrest merged 2 commits into
reactchartjs:masterfrom
andreme:fix-destroychart

Conversation

@andreme

@andreme andreme commented Oct 28, 2019

Copy link
Copy Markdown
Contributor

I've seen error this error in my logs:

TypeError: Unable to get property 'config' of undefined or null reference
  at ChartComponent.prototype.destroyChart(/vendor.js:46065:21)
  at ChartComponent.prototype.componentWillUnmount(/vendor.js:46001:21)

There might be a different issue, but this seems like a safe fix.

@andreme

andreme commented Oct 28, 2019

Copy link
Copy Markdown
Contributor Author

This seems to be the root cause: chartjs/Chart.js#6630

@ichadw

ichadw commented Jan 10, 2020

Copy link
Copy Markdown

can @jerairrest merge this ? we need this to handle error on edge browser...

Comment thread src/index.js Outdated
Co-Authored-By: Jeremy Ayerst <jeremyayerst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants