Use document when getRootNode is unsupported#6630
Merged
Merged
Conversation
etimberg
approved these changes
Oct 28, 2019
benmccann
approved these changes
Oct 28, 2019
benmccann
left a comment
Contributor
There was a problem hiding this comment.
Lgtm. I think we need to create a 2.9 branch instead of merging this into master
Contributor
|
@benmccann I don't want to entry in your decision, but be aware that version 2.9.x is currently not working with IE and EDGE and I hope you can apply this update into the master as soon as possible. |
Contributor
|
|
Member
|
Ok, so how should we handle this? I'm thinking:
|
Contributor
|
That sounds good to me |
Member
Author
|
Did another PR against 2.9 branch, would that be simpler? |
Member
|
Works for me |
|
@etimberg Thank you. Would you mind doing a release as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6629