Migrate thread_parallel.cpp to ET_CHECK_OR_RETURN_FALSE#8977
Merged
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8977
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a8a0e57 with merge base 484231c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kimishpatel
reviewed
Mar 6, 2025
| "//executorch/runtime/core/exec_aten/util:tensor_util" + aten_suffix, | ||
| ], | ||
| ) | ||
| runtime.cxx_library( |
Contributor
There was a problem hiding this comment.
i dont know the details on aten variant but are you removing it because you determined that it is not needed?
Contributor
Author
There was a problem hiding this comment.
yes, it was only needed because of the aten-suffixed tensor_util dep, which is gone now
kimishpatel
approved these changes
Mar 6, 2025
This was referenced Mar 17, 2025
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
It's convenient if this thing doesn't depend on tensor_util, and conveniently the dependency was deprecated anyway. ghstack-source-id: cb09842 ghstack-comment-id: 2702239582 Pull Request resolved: pytorch/executorch#8977
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
It's convenient if this thing doesn't depend on tensor_util, and conveniently the dependency was deprecated anyway. ghstack-source-id: 4e6347d ghstack-comment-id: 2702239582 Pull Request resolved: pytorch/executorch#8977
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's convenient if this thing doesn't depend on tensor_util, and conveniently the dependency was deprecated anyway.