Make serial parallel_for "polyfill" iterate backwards in debug builds#9044
Merged
Make serial parallel_for "polyfill" iterate backwards in debug builds#9044
Conversation
This was referenced Mar 11, 2025
JacobSzwejbka
approved these changes
Mar 11, 2025
Contributor
JacobSzwejbka
left a comment
There was a problem hiding this comment.
The debug loop looks fine to me, though do we have much other NDEBUG ifdefs in the codebase? Is that a mode people often use with ET?
Contributor
Author
Release builds define NDEBUG. it's the same macro that gates |
This PR needs a
|
swolchok
added a commit
that referenced
this pull request
Mar 12, 2025
This reverts commit 05a160e. Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)"" This reverts commit 815eaff. Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)"" This reverts commit 10bb615. ghstack-source-id: 2c4a363 ghstack-comment-id: 2718584686 Pull Request resolved: #9190
swolchok
added a commit
that referenced
this pull request
Mar 12, 2025
This reverts commit 05a160e. Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)"" This reverts commit 815eaff. Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)"" This reverts commit 10bb615. ghstack-source-id: 2c4a363 ghstack-comment-id: 2718584686 Pull Request resolved: #9190
swolchok
added a commit
that referenced
this pull request
Mar 12, 2025
This reverts commit 05a160e. Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)"" This reverts commit 815eaff. Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)"" This reverts commit 10bb615. ghstack-source-id: 2c4a363 ghstack-comment-id: 2718584686 Pull Request resolved: #9190
This was referenced Mar 17, 2025
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Catches users who assume it goes forwards in order (like my attempt to use parallel_for in reductions, whoops). ghstack-source-id: 9b72632 ghstack-comment-id: 2707052203 Pull Request resolved: pytorch/executorch#9044
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catches users who assume it goes forwards in order (like my attempt to use parallel_for in reductions, whoops).