[Windows] Support windows for pybindings install in setup.py#8917
[Windows] Support windows for pybindings install in setup.py#8917SamGondelman wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8917
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b14e4dd with merge base 24671a9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Set the src directory based on build configuration for windows. Rename _portable_lib.* to _portable_lib.cp* to avoid _portable_lib.lib is selected on windows. For pytorch#4661
628aeec to
b14e4dd
Compare
|
There are some merge conflicts now |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
1 similar comment
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Summary
Cherry-pick of #5382, brought up to date
Test plan
With this change, it might be possible to build Windows now, once the other PRs are merged?