Skip to content

[Build] Support windows for pybindings install in setup.py#5382

Closed
python3kgae wants to merge 1 commit intopytorch:mainfrom
python3kgae:built_extension_path
Closed

[Build] Support windows for pybindings install in setup.py#5382
python3kgae wants to merge 1 commit intopytorch:mainfrom
python3kgae:built_extension_path

Conversation

@python3kgae
Copy link
Contributor

@python3kgae python3kgae commented Sep 15, 2024

Set the src directory based on build configuration for windows. Rename _portable_lib.* to _portable_lib.cp* to avoid _portable_lib.lib is selected on windows.

For #4661

@python3kgae
[Build] Support windows for pybindings install in setup.py
55821aa 
Set the src directory based on build configuration for windows.
Rename _portable_lib.* to _portable_lib.cp* to avoid _portable_lib.lib is selected on windows.

For pytorch#4661
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5382

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2024
@python3kgae
Copy link
Contributor Author

python3kgae commented Sep 15, 2024

Tested on WSL and Windows.
Need help for Mac and native Linux.

@SamGondelman SamGondelman mentioned this pull request Mar 4, 2025
Open
@shoumikhin
Copy link
Contributor

shoumikhin commented Mar 17, 2025

@tarun292, @kirklandsign can you please take a look?

@byjlw byjlw requested a review from SS-JIA March 17, 2025 16:16
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 17, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@SS-JIA
Copy link
Contributor

SS-JIA commented Mar 17, 2025

The changes contained in this PR were landed as part of the recent windows support effort, i.e. #9198. Closing this PR because of that.

@SS-JIA SS-JIA closed this Mar 17, 2025
@github-actions
Copy link

github-actions bot commented Mar 17, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SS-JIA SS-JIA Awaiting requested review from SS-JIA

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@python3kgae @shoumikhin @SS-JIA @jathu @facebook-github-bot