[ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y in conv2d pw.#7972
Merged
kirklandsign merged 3 commits intomainfrom Jan 27, 2025
Merged
[ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y in conv2d pw.#7972kirklandsign merged 3 commits intomainfrom
kirklandsign merged 3 commits intomainfrom
Conversation
Pull Request resolved: #7814 This diff is related to the use of push constants for convolutional pw (pointwise) in Executorch's Vulkan backend. This optimization improves performance and memory usage. ghstack-source-id: 263238730 @exported-using-ghexport Differential Revision: [D68400677](https://our.internmc.facebook.com/intern/diff/D68400677/)
Pull Request resolved: #7815 This diff contains minor improvements to the conv2d pw and dw bounds check in the Vulkan backend for Executorch. ghstack-source-id: 263238731 @exported-using-ghexport Differential Revision: [D68400689](https://our.internmc.facebook.com/intern/diff/D68400689/)
Pull Request resolved: #7816 This diff splits the `TILE_SIZE` variable in the `conv2d_pw` GLSL code into `TILE_SIZE_X` and `TILE_SIZE_Y`. This change is made so tile size in different dimensions can be tuned separately. ghstack-source-id: 263238734 @exported-using-ghexport Differential Revision: [D68400783](https://our.internmc.facebook.com/intern/diff/D68400783/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7972
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit fdb4f3f with merge base e78ed83 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kirklandsign
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #7816
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/48/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/48/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/47/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/48/orig
@diff-train-skip-merge
cc @SS-JIA @manuelcandales