BUG: correct mb03rd for default X=None argument#139
Merged
roryyorke merged 2 commits intopython-control:masterfrom Jan 9, 2021
Merged
BUG: correct mb03rd for default X=None argument#139roryyorke merged 2 commits intopython-control:masterfrom
roryyorke merged 2 commits intopython-control:masterfrom
Conversation
Collaborator
Author
|
Failing in the Python 2.7 builds because I used @ in the test; also failing in all conda recipe builds, no sure why. Here's an import failure in from Ubuntu Bionic / Python 3.8 / AMD64 / conda / OpenBLAS (https://travis-ci.org/github/python-control/Slycot/jobs/752107811): I don't think this is caused by this PR, which doesn't change build settings. |
Added a test for this case.
f8b11d0 to
1cadd32
Compare
Collaborator
Author
|
2.7 now passing. |
bnavigator
approved these changes
Dec 30, 2020
This was referenced Dec 31, 2020
bnavigator
reviewed
Jan 5, 2021
Collaborator
bnavigator
left a comment
There was a problem hiding this comment.
Some whitespace style review comments (mainly to retrigger Travis)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a test for this case.
@repagh I think this is a reasonably simple fix -- do you have time to review it?