Multi-dimensional learning rate (sigma0) for AdamW#462
Merged
Conversation
…ion tests for multi-dim sigma0's
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #462 +/- ##
===========================================
- Coverage 99.04% 99.03% -0.01%
===========================================
Files 52 52
Lines 3545 3527 -18
===========================================
- Hits 3511 3493 -18
Misses 34 34 ☔ View full report in Codecov by Sentry. |
…ts / odd powers. tests: reduces eis integration coverage, increases test diversity in spm integration tests
martinjrobins
approved these changes
Sep 10, 2024
martinjrobins
left a comment
Contributor
There was a problem hiding this comment.
looks good to me. I see that you fixed a few of the cost funtions gradient calculations as well
# Conflicts: # pybop/costs/_likelihoods.py # tests/integration/test_eis_parameterisation.py # tests/integration/test_spm_parameterisations.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds multi-dimensional sigma0 values to AdamW, updates integration tests for multi-dimensional sigma0, and updates the default value in GaussianLogLikehood sigma0
Issue reference
Fixes #461
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.