Replace pybop.MAP with pybop.LogPosterior#483
Merged
Conversation
… initial notebook, updts tests and bugfixes, adds __repr__ to parameters, refactors logpdfS1 for JointPrior
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #483 +/- ##
===========================================
+ Coverage 99.01% 99.03% +0.02%
===========================================
Files 52 52
Lines 3555 3527 -28
===========================================
- Hits 3520 3493 -27
+ Misses 35 34 -1 ☔ View full report in Codecov by Sentry. |
# Conflicts: # examples/notebooks/comparing_cost_functions.ipynb # examples/notebooks/cost-compute-methods.ipynb # examples/notebooks/multi_model_identification.ipynb
martinjrobins
requested changes
Sep 9, 2024
martinjrobins
left a comment
Contributor
There was a problem hiding this comment.
looks great @BradyPlanden, a few suggestions below:
martinjrobins
approved these changes
Sep 9, 2024
Contributor
|
I would merge, but are we merging or squash merging? |
Member
Author
|
I'm happy with either. I've been merging as is, with squashes close to a release for cherry picking, or if the branch commits are quite noisy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pybop.MAPwithpybop.LogPosterior,Issue reference
Fixes #459
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.