Updates for numpy 2 compatibility#372
Merged
Merged
Conversation
Member
Author
|
The Pints's optimisers |
Member
Author
|
We can merge this PR ahead of the Pints's updates. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #372 +/- ##
===========================================
+ Coverage 97.29% 97.47% +0.18%
===========================================
Files 46 42 -4
Lines 2805 2418 -387
===========================================
- Hits 2729 2357 -372
+ Misses 76 61 -15 ☔ View full report in Codecov by Sentry. |
BradyPlanden
approved these changes
Jun 24, 2024
BradyPlanden
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for the changes @NicolaCourtier.
|
PINTS is fixed now! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates are required to use Numpy 2.0. As for Pints (see their PR 1531), we just need to replace
np.array(x, copy=False)withnp.asarray(x).Issue reference
Fixes #367.
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.