Skip to content

Updates for numpy 2 compatibility#1531

Merged
MichaelClerx merged 3 commits into
mainfrom
numpy-2
Jul 8, 2024
Merged

Updates for numpy 2 compatibility#1531
MichaelClerx merged 3 commits into
mainfrom
numpy-2

Conversation

@MichaelClerx

@MichaelClerx MichaelClerx commented Jun 17, 2024

Copy link
Copy Markdown
Member
  1. Not many changes in PINTS luckily, just replacing a np.array(x, copy=False) with np.asarray(x)
  2. Remaining errors are in pycma. These are already fixed in development but we'll need to wait for a new release.

@codecov

codecov Bot commented Jun 17, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3f2f153) to head (f5f1a37).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1531   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines         9693      9693           
=========================================
  Hits          9693      9693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelClerx

Copy link
Copy Markdown
Member Author

Fixes #1530

@MichaelClerx

Copy link
Copy Markdown
Member Author

The cma issue is also what's breaking the notebook tests right now

@nikohansen

nikohansen commented Jul 5, 2024

Copy link
Copy Markdown

I just released the latest pycma 3.4.0 which is compatible with numpy 2.0.

@MichaelClerx

Copy link
Copy Markdown
Member Author

Thanks @nikohansen !

@MichaelClerx

MichaelClerx commented Jul 8, 2024

Copy link
Copy Markdown
Member Author

In the meantime, a scipy update remove cumtrapz which had been deprecated, so fixed that too. It means the test that used this function now requires scipy 1.12, released Jan 2024 Updated it to work with old and new.

@chonlei chonlei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Michael!

@MichaelClerx MichaelClerx merged commit a4fc16e into main Jul 8, 2024
@MichaelClerx MichaelClerx deleted the numpy-2 branch July 8, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants