Adds Transformation class#357
Merged
BradyPlanden merged 25 commits intoAug 1, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #357 +/- ##
===========================================
+ Coverage 98.11% 98.28% +0.16%
===========================================
Files 44 46 +2
Lines 2708 2907 +199
===========================================
+ Hits 2657 2857 +200
+ Misses 51 50 -1 ☔ View full report in Codecov by Sentry. |
…, and composed transformations, updts for example API usage
18 tasks
3ba0b1f to
4e1f845
Compare
BradyPlanden
commented
Jul 10, 2024
NicolaCourtier
left a comment
Member
There was a problem hiding this comment.
Great work implementing the transformation classes! To retain modularity, let's make transformation a property of the Parameters class (as well as each Parameter) instead of the cost/optimiser.
…-scale-parameters # Conflicts: # pybop/costs/base_cost.py # pybop/costs/fitting_costs.py
…lue for multi_signal w/ gaussian likelihood
NicolaCourtier
approved these changes
Aug 1, 2024
NicolaCourtier
left a comment
Member
There was a problem hiding this comment.
Thanks @BradyPlanden, transformations look like a useful addition!
3fd3ea3 to
8dca6d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a transformation class for
BaseCostclasses. This class applies a transformation to the parameter space to a latent space for improved optimisation / sampling.Issue reference
Fixes #92
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.