add expires parameter to base class#233
Merged
ionrock merged 1 commit intopsf:masterfrom Oct 16, 2020
Merged
Conversation
Author
|
Hello, @ionrock. Do you guys have a timeline for the when the next version will be released? It would be great to have this functionality available now that it is merged. If there is anything I can do to assist in the process, please let me know. I would be happy to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #168 but I have removed all the Redis related code as it is not needed for my use case.
I have some other cache types based on BaseCache and would like to be able to pass through an expires parameter so that I can set a custom TTL in our backend cache.