Added support for expiry on the Redis backend.#206
Closed
roblinton wants to merge 2 commits intopsf:masterfrom
roblinton:redis-ttl
Closed
Added support for expiry on the Redis backend.#206roblinton wants to merge 2 commits intopsf:masterfrom roblinton:redis-ttl
roblinton wants to merge 2 commits intopsf:masterfrom
roblinton:redis-ttl
Conversation
The CacheController does not pass an expiry key to supported backends, aka. Redis. This commit adds support for deriving a TTL from the response headers and passing that to the cache backend allowing the cache to expire old caches automatically.
ghost
reviewed
Nov 11, 2019
Redis complains when the `ex` value is set to 0 in set(). This turns 0 values into None. If a truly incorrect value is present, it probably makes sense to raise the exception.
sileht
approved these changes
Mar 2, 2020
|
Hello @ionrock, any chance of this getting merged? |
Author
|
Implemented with #233 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CacheController does not pass an expiry key to supported backends, aka. Redis. This commit adds support for deriving a TTL from the response headers and passing that to the cache backend allowing the cache to expire old caches automatically.
When using this library in an environment with lots of traffic and rapidly expiring caches we noticed that the Redis backend never received an expiry argument. We added this before noticing an existing pull request for the same functionality. That pull request appears to be fairly old and no longer merges so I've updated our changes to incorporate some of the notes on the old one.
Some notes: