docs: correct changeset guidance in CONTRIBUTING#2549
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The changeset workflow was documented only under "Publishing (Maintainers only)", which wrongly implied contributors don't add changesets and told everyone to "flag them all". Both contradict how the repo actually works: contributors add a changeset in their PR, and the
fixed: [["@react-spring/*"]]group in.changeset/config.jsonversion-locks every package, so flagging one bumps them all.What
Document changeset creation as a contributor step under "Sending a PR" with the correct "flag only the package(s) you changed" guidance, and simplify the release flow to just bump and publish (the changesets already exist from merged PRs).