fix: cache output number parsing in createStringInterpolator#2547
Conversation
🦋 Changeset detectedLatest commit: 4313236 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
heads up: the contributing.md file implies that only maintainers need to worry about changesets, and says
I'm guessing "maintainers only" isn't right based on the above comment, and I'm not sure if "flag them all" is right, since I see other PRs that don't flag all packages |
|
Thanks for the contribution, i've done a follow up PR for the contributing recommendations – #2549, thanks for flagging. |
|
Any chance this could be backported to 10.x 🙏? Or can you share if there's any timeline on when 11.x will be stable? |
|
No timeline, very much down time development. I'll look at back porting today. |
(cherry picked from commit e8e96a7)
|
The backport helped us a lot. Thanks! |
Why
Starting in version 10.1.0, this code is very slow when showing a chart with a large number of points.
What
Instead of calculating the value in every iteration of the loop, the numbers are only calculated once.
Checklist