+poppler.freedesktop.org by jonchang · Pull Request #432 · pkgxdev/pantry

jonchang · 2023-02-28T17:13:07Z

also add the poppler-data package separately. (Namespacing is great!)

what-the-diff · 2023-02-28T17:13:20Z

Added a new project poppler.freedesktop.org/poppler-data
Updated the package file for poppler to include this dependency and also added some other dependencies that were missing from it's original package file (libjpeg, libpng)
Also updated the build script of popper to install static libraries as well in addition to shared ones so we can link against them later on when building our own projects with gxpkgs toolchain installed locally or via docker image built using these packages files

jonchang · 2023-02-28T18:08:20Z

~~Looks like we will need to package libopenjpeg and libtiff~~ done

Refs #432

mxcl · 2023-03-01T11:59:43Z

Added:

jonchang · 2023-03-03T02:59:49Z

Odd failure on darwin/x86-64.

g-ir-scanner: link: gcc -o /opt/poppler.freedesktop.org/src-v22.12.0/build_shared/glib/tmp-introspectimjfx6ue/Poppler-0.18 /opt/poppler.freedesktop.org/src-v22.12.0/build_shared/glib/tmp-introspectimjfx6ue/Poppler-0.18.o -L. -Wl,-rpath,. -L/opt/poppler.freedesktop.org/src-v22.12.0/build_shared -Wl,-rpath,/opt/poppler.freedesktop.org/src-v22.12.0/build_shared -L/opt/poppler.freedesktop.org/src-v22.12.0/build_shared/glib -Wl,-rpath,/opt/poppler.freedesktop.org/src-v22.12.0/build_shared/glib -lpoppler-glib -lpoppler -L/opt/gnome.org/glib/v2.72.4/lib/pkgconfig/../../lib -L/opt/gnome.org/glib/v2.72.4/lib/pkgconfig/../../../../../gnu.org/gettext/v0/lib -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lintl -Wl,-rpath,/opt
dyld[49133]: Library not loaded: /usr/local/opt/freetype/lib/libfreetype.6.dylib
  Referenced from: <CF326A57-9BEF-336D-BC3B-029D12F45C90> /opt/cairographics.org/v1.16.0/lib/libcairo.2.dylib
  Reason: tried: '/usr/local/opt/freetype/lib/libfreetype.6.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/usr/local/opt/freetype/lib/libfreetype.6.dylib' (no such file), '/usr/local/opt/freetype/lib/libfreetype.6.dylib' (no such file), '/opt/poppler.freedesktop.org/src-v22.12.0/build_shared/libfreetype.6.dylib' (no such file), '/opt/poppler.freedesktop.org/src-v22.12.0/build_shared/glib/libfreetype.6.dylib' (no such file)
Command '['/opt/poppler.freedesktop.org/src-v22.12.0/build_shared/glib/tmp-introspectimjfx6ue/Poppler-0.18', '--introspect-dump=/opt/poppler.freedesktop.org/src-v22.12.0/build_shared/glib/tmp-introspectimjfx6ue/functions.txt,/opt/poppler.freedesktop.org/src-v22.12.0/build_shared/glib/tmp-introspectimjfx6ue/dump.xml']' died with <Signals.SIGABRT: 6>.

On darwin/aarch64:

% otool -L libcairo.2.dylib
libcairo.2.dylib:
	@rpath/cairographics.org/v1.16.0/lib/libcairo.2.dylib (compatibility version 11603.0.0, current version 11603.0.0)
	@rpath/pixman.org/v0/lib/libpixman-1.0.40.0.dylib (compatibility version 41.0.0, current version 41.0.0)
	@rpath/freedesktop.org/fontconfig/v2/lib/libfontconfig.1.dylib (compatibility version 14.0.0, current version 14.0.0)
	@rpath/freetype.org/v2/lib/libfreetype.6.18.3.dylib (compatibility version 6.0.0, current version 6.18.3)
	@rpath/libpng.org/v1/lib/libpng16.16.dylib (compatibility version 56.0.0, current version 56.0.0)
	@rpath/zlib.net/v1/lib/libz.1.2.13.dylib (compatibility version 1.0.0, current version 1.2.13)
	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices (compatibility version 1.0.0, current version 61.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1319.0.0)
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1953.255.0)
	/System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics (compatibility version 64.0.0, current version 1690.3.3)

But on darwin/x86-64:

% otool -L libcairo.dylib
libcairo.dylib:
	@rpath/cairographics.org/v1.16.0/lib/libcairo.2.dylib (compatibility version 11603.0.0, current version 11603.0.0)
	@rpath/pixman.org/v0/lib/libpixman-1.0.40.0.dylib (compatibility version 41.0.0, current version 41.0.0)
	@rpath/libpng.org/v1/lib/libpng16.16.dylib (compatibility version 56.0.0, current version 56.0.0)
	/usr/local/opt/freetype/lib/libfreetype.6.dylib (compatibility version 25.0.0, current version 25.3.0)
	@rpath/zlib.net/v1/lib/libz.1.2.13.dylib (compatibility version 1.0.0, current version 1.2.13)
	/usr/local/opt/libxrender/lib/libXrender.1.dylib (compatibility version 5.0.0, current version 5.0.0)
	/usr/local/opt/libx11/lib/libX11.6.dylib (compatibility version 11.0.0, current version 11.0.0)
	/usr/local/opt/libxext/lib/libXext.6.dylib (compatibility version 11.0.0, current version 11.0.0)
	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices (compatibility version 1.0.0, current version 56.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.0.0)
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1856.105.0)
	/System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics (compatibility version 64.0.0, current version 1557.3.2)

The build for intel macs seems to reference libraries that shouldn't exist.

jonchang · 2023-03-03T03:02:13Z

@jhheider any chance you could kick off a rebuild for intel darwin for cairographics.org? It seems to be picking up Homebrew X11 libraries that it shouldn't be using.

jhheider · 2023-03-03T03:32:56Z

Yup.

jhheider · 2023-03-03T03:36:29Z

Can confirm those paths aren't present on our self-hosted builder, so that's a consequence of GHA macos-11.

jhheider · 2023-03-03T03:44:30Z

Done: https://github.com/teaxyz/pantry.core/actions/runs/4319977717

jhheider · 2023-03-03T03:46:49Z

$ otool -l cairographics.org/v1.16.0/lib/libcairo.2.dylib | grep dylib
cairographics.org/v1.16.0/lib/libcairo.2.dylib:
         name @rpath/cairographics.org/v1.16.0/lib/libcairo.2.dylib (offset 24)
         name @rpath/pixman.org/v0/lib/libpixman-1.0.40.0.dylib (offset 24)
         name @rpath/freedesktop.org/fontconfig/v2/lib/libfontconfig.1.dylib (offset 24)
         name @rpath/freetype.org/v2/lib/libfreetype.6.18.3.dylib (offset 24)
         name @rpath/libpng.org/v1/lib/libpng16.16.dylib (offset 24)
         name @rpath/zlib.net/v1/lib/libz.1.2.13.dylib (offset 24)
         name /usr/lib/libSystem.B.dylib (offset 24)

jonchang · 2023-03-03T04:47:44Z

Tested the linux/x86-64 artifacts locally, it looks like there's an issue with relocation. Going to see what I can find out about what patchelf is doing (or not doing)

jhheider · 2023-03-03T04:49:18Z

We've been developing more issues recently. For many things, using PIE will fix it, but not for all things. Your expertise in the depths of binary formats is sorely appreciated.

jonchang · 2023-03-03T04:52:45Z

I note that we're using patchelf 1.17.0 still, but .2 released a little while ago and has a few fixes for out of bounds segment references.

jhheider · 2023-03-03T04:55:55Z

Triggering the build.

jhheider · 2023-03-05T03:50:45Z

Yeah, confirmed that it's definitely PIE.

mxcl · 2023-03-05T13:03:13Z

+  curl.se: '*'
+  freedesktop.org/fontconfig: '>=2.13'
+  freetype.org: '>=2.10'
+  gnome.org/glib: '>=2.64'


I think ^2.64 is more likely. Using >= includes a potential future v3. Same for the rest.

mxcl · 2023-03-05T13:05:47Z

+  libjpeg-turbo.org: '*'
+  libpng.org: '*'
+  openjpeg.org: '*'
+  poppler.freedesktop.org/poppler-data: '*'


I would have preferred poppler.freedesktop.org/data but the beauty of namespacing is this is contained so not important.

mxcl

Biggest dep tree so far! Great work.

mxcl added a commit that referenced this pull request Mar 1, 2023

+libtiff

99479a2

Refs #432

mxcl mentioned this pull request Mar 1, 2023

+libtiff #433

Merged

mxcl added a commit that referenced this pull request Mar 1, 2023

+libtiff

4f1c849

Refs #432

+poppler.freedesktop.org

2ccc585

see if explicit PIC fixes segfaults

d565dac

jhheider mentioned this pull request Mar 5, 2023

use PIC/PIE on linux-x86-64 pkgxdev/pantry.core#464

Merged

8 tasks

jhheider added 2 commits March 4, 2023 20:55

that will teach me to use the web editor

d725dc9

this, maybe

09eea61

mxcl reviewed Mar 5, 2023

View reviewed changes

mxcl approved these changes Mar 5, 2023

View reviewed changes

mxcl merged commit e70d0dd into pkgxdev:main Mar 5, 2023

This was referenced Mar 7, 2023

+ansible #469

Merged

+twine #471

Merged

py cleaning #486

Merged

jhheider mentioned this pull request Apr 1, 2023

+poppler #322

Closed

Conversation

jonchang commented Feb 28, 2023

Uh oh!

what-the-diff Bot commented Feb 28, 2023

Uh oh!

jonchang commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mxcl commented Mar 1, 2023

Uh oh!

jonchang commented Mar 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonchang commented Mar 3, 2023

Uh oh!

jhheider commented Mar 3, 2023

Uh oh!

jhheider commented Mar 3, 2023

Uh oh!

jhheider commented Mar 3, 2023

Uh oh!

jhheider commented Mar 3, 2023

Uh oh!

jonchang commented Mar 3, 2023

Uh oh!

jhheider commented Mar 3, 2023

Uh oh!

jonchang commented Mar 3, 2023

Uh oh!

jhheider commented Mar 3, 2023

Uh oh!

jhheider commented Mar 5, 2023

Uh oh!

mxcl Mar 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mxcl Mar 5, 2023

Choose a reason for hiding this comment

Uh oh!

mxcl left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jonchang commented Feb 28, 2023 •

edited

Loading

jonchang commented Mar 3, 2023 •

edited

Loading

mxcl Mar 5, 2023 •

edited

Loading